Add size_t length argument to v8::ArrayBuffer::Allocator::Free.

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1617 matching lines @@
 class ShellArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
  public:
   virtual void* Allocate(size_t length) {
     void* result = malloc(length);
     memset(result, 0, length);
     return result;
   }
   virtual void* AllocateUninitialized(size_t length) {
     return malloc(length);
   }
-  virtual void Free(void* data) { free(data); }
+  virtual void Free(void* data, size_t) { free(data); }
+  virtual void Free(void* data) { UNREACHABLE(); }

[Dmitry Lomov (no reviews), 2013/08/02 11:32:57]

The second overload is a workaround for gcc warning  ‘virtual void
v8::ArrayBuffer::Allocator::Free(void*)’ was hidden
by ‘virtual void v8::ShellArrayBufferAllocator::Free(void*, size_t)’
[-Werror=overloaded-virtual].

It _looks like_ this is not an error for Blink/chromium (as in, I was able to
build blink and chromium agains this patch on Linux). 
Bug https://code.google.com/p/v8/issues/detail?id=2823 tracks cleaning up the
interface

[Michael Starzinger, 2013/08/02 12:13:06]

nit: Let's add a TODO here referring to the issue number. Because removing the
method from the interface will not be enough to find this override.

 };
 
 
 int Shell::Main(int argc, char* argv[]) {
   if (!SetOptions(argc, argv)) return 1;
   v8::V8::InitializeICU();
 #ifndef V8_SHARED
   i::FLAG_harmony_array_buffer = true;
   i::FLAG_harmony_typed_arrays = true;
   i::FLAG_trace_hydrogen_file = "hydrogen.cfg";
@@ skipping 77 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif