Host side implementation of ARC tts.

Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC tts engines can and do manage their own voices, it is left to the user to pick a system voice inside of ARC. This also mitigates the issue of multiple tts engines speaking at once which can also occur if two separate ARC tts engines are used.

BUG=628963
TEST=build both sides and exercise tts features including start, end, interrupted, error events. In addition, observe queued and flushed speak calls through ChromeVox. Make adjustments in rate and pitch through the possible ranges (0 to 5.0) and observe expected changes. Do this for multiple engines from the Play Store.

Committed: https://crrev.com/9ea8fa35f638c4be2d32196e20348d3f05112a93
Cr-Commit-Position: refs/heads/master@{#409267}

[David Tseng, 2016-07-26 15:38:10]

Description was changed from

==========
Host side implementation of ARC tts.
==========

to

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed events
through ChromeVox. Do this for multiple engines from the Play Store.
==========

[David Tseng, 2016-07-26 15:38:11]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, hidehiko@chromium.org

[David Tseng, 2016-07-26 15:38:46]

hidehiko for arc
dmazzoni for tts

[David Tseng, 2016-07-26 16:14:55]

Description was changed from

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed events
through ChromeVox. Do this for multiple engines from the Play Store.
==========

to

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed speak calls
through ChromeVox. Make adjustments in rate and pitch through the possible
ranges (0 to 5.0) and observe expected changes. Do this for multiple engines
from the Play Store.
==========

[hidehiko, 2016-07-26 17:59:18]

https://codereview.chromium.org/2180263002/diff/1/components/arc/BUILD.gn
File components/arc/BUILD.gn (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/BUILD.gn#new...
components/arc/BUILD.gn:57: "tts/arc_tts_service.cc",
Could you update gyp file, too?

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/arc_b...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/arc_b...
components/arc/common/arc_bridge.mojom:91: OnTtsInstanceReady@121(TtsInstance
instance_ptr);
Could you add [MinVersion=15], and increment "Next MinVersion: " at line 28?

FYI: some other eng is also adding new Mojo, so the MinVersion may need to be
updated on rebasing.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
File components/arc/common/tts.mojom (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:24: OnTtsEvent(uint32 utteranceId, TtsEventType
event_type);
Could you add @ index? Ditto for TtsInstance's methods below.

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/DEPS
File components/arc/tts/DEPS (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/DEPS#new...
components/arc/tts/DEPS:2: "+chrome/browser/speech",
Modules under components/ cannot depend on ones under chrome/.
Could you split the dependency? Or could you move TtsService into
chrome/browser/chromeos/arc/... ?

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
File components/arc/tts/arc_tts_service.cc (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:18: ArcTtsService::~ArcTtsService() {}
arc_bridge_service()->tts()->RemoveObserver(this);

is needed.

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:49:
TtsController::GetInstance()->OnTtsEvent(id, chrome_event_type, 0, "");
Could you comment 0 and "" for what?

[dmazzoni, 2016-07-26 22:12:58]

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
File components/arc/tts/arc_tts_service.cc (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:49:
TtsController::GetInstance()->OnTtsEvent(id, chrome_event_type, 0, "");
To match other engines, I think the "end" event should be sent with the
utterance length as the char_index.

You can install TTS Debug from the web store and it will run through a bunch of
manual and automated tests to make sure you've implemented a bunch of things
correctly.

[Luis Héctor Chávez, 2016-07-26 22:48:11]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-07-26 22:48:12]

drive-by

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:42: arc::mojom::TtsInstance* tts =
GetArcTts();
DCHECK_CURRENTLY_ON(BrowserThread::UI);

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:56: arc::mojom::TtsInstance* tts =
GetArcTts();
DCHECK_CURRENTLY_ON(BrowserThread::UI);

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
File components/arc/common/tts.mojom (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:3: // found in the LICENSE file.
// Next MinVersion=1

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:7: enum TtsEventType {
Can this change in the future? If so, please add an [Extensible] tag.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:22: interface TtsHost {
// Next Method ID: 1

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:27: interface TtsInstance {
// Next Method ID: 3

[David Tseng, 2016-07-27 22:51:00]

https://codereview.chromium.org/2180263002/diff/1/components/arc/BUILD.gn
File components/arc/BUILD.gn (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/BUILD.gn#new...
components/arc/BUILD.gn:57: "tts/arc_tts_service.cc",
On 2016/07/26 17:59:18, hidehiko wrote:
> Could you update gyp file, too?

Acknowledged.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/arc_b...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/arc_b...
components/arc/common/arc_bridge.mojom:91: OnTtsInstanceReady@121(TtsInstance
instance_ptr);
On 2016/07/26 17:59:18, hidehiko wrote:
> Could you add [MinVersion=15], and increment "Next MinVersion: " at line 28?
> 
> FYI: some other eng is also adding new Mojo, so the MinVersion may need to be
> updated on rebasing.

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
File components/arc/common/tts.mojom (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:3: // found in the LICENSE file.
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> // Next MinVersion=1

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:7: enum TtsEventType {
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> Can this change in the future? If so, please add an [Extensible] tag.

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:22: interface TtsHost {
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> // Next Method ID: 1

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:24: OnTtsEvent(uint32 utteranceId, TtsEventType
event_type);
On 2016/07/26 17:59:18, hidehiko wrote:
> Could you add @ index? Ditto for TtsInstance's methods below.

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/common/tts.m...
components/arc/common/tts.mojom:27: interface TtsInstance {
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> // Next Method ID: 3

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/DEPS
File components/arc/tts/DEPS (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/DEPS#new...
components/arc/tts/DEPS:2: "+chrome/browser/speech",
On 2016/07/26 17:59:18, hidehiko wrote:
> Modules under components/ cannot depend on ones under chrome/.
> Could you split the dependency? Or could you move TtsService into
> chrome/browser/chromeos/arc/... ?

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
File components/arc/tts/arc_tts_service.cc (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:18: ArcTtsService::~ArcTtsService() {}
On 2016/07/26 17:59:18, hidehiko wrote:
> arc_bridge_service()->tts()->RemoveObserver(this);
> 
> is needed.

Done.

[hidehiko, 2016-07-28 05:39:53]

You may forget to add the moved files?

[David Tseng, 2016-07-28 19:32:39]

On 2016/07/28 05:39:53, hidehiko wrote:
> You may forget to add the moved files?

No, I had moved everything to tts_chromeos.cc. In the latest patchset, I went
ahead and just moved TtsHost out to chrome/browser/speech/tts_chromeos.cc to
remove the illegal DEPS.

[hidehiko, 2016-07-29 09:25:53]

Sorry, I misunderstood your intention.

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:42: arc::mojom::TtsInstance* tts =
GetArcTts();
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> DCHECK_CURRENTLY_ON(BrowserThread::UI);

ping?

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:56: arc::mojom::TtsInstance* tts =
GetArcTts();
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> DCHECK_CURRENTLY_ON(BrowserThread::UI);

ping?

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
File components/arc/tts/arc_tts_service.cc (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:49:
TtsController::GetInstance()->OnTtsEvent(id, chrome_event_type, 0, "");
On 2016/07/26 22:12:58, dmazzoni wrote:
> To match other engines, I think the "end" event should be sent with the
> utterance length as the char_index.
> 
> You can install TTS Debug from the web store and it will run through a bunch
of
> manual and automated tests to make sure you've implemented a bunch of things
> correctly.
> 

ping?

https://codereview.chromium.org/2180263002/diff/60001/chrome/browser/speech/t...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/60001/chrome/browser/speech/t...
chrome/browser/speech/tts_chromeos.cc:119: if (tts_instance && tts_instance !=
last_tts_instance_) {
This does not work.
E.g.; tts_instance is destructed once, and recreated at the same memory
location.

Please make a standalone class, and observe OnInstance{Ready,Close}().
Also, please let keep the instance track by ArcServiceManager. The instance
should be added in arc_service_launcher.cc.

https://codereview.chromium.org/2180263002/diff/60001/components/arc/common/a...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/60001/components/arc/common/a...
components/arc/common/arc_bridge.mojom:95: [MinVersion=16]
OnTtsInstanceReady@123(TtsInstance instance_ptr);
Indent.

https://codereview.chromium.org/2180263002/diff/60001/components/arc/tts/arc_...
File components/arc/tts/arc_tts_service.h (right):

https://codereview.chromium.org/2180263002/diff/60001/components/arc/tts/arc_...
components/arc/tts/arc_tts_service.h:17: class ArcTtsService : public
ArcService,
This is no longer needed here. Instead you'll need to create another service in
chrome/browser/chromeos/arc/

[David Tseng, 2016-08-01 20:21:42]

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:42: arc::mojom::TtsInstance* tts =
GetArcTts();
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> DCHECK_CURRENTLY_ON(BrowserThread::UI);

Done.

https://codereview.chromium.org/2180263002/diff/1/chrome/browser/speech/tts_c...
chrome/browser/speech/tts_chromeos.cc:56: arc::mojom::TtsInstance* tts =
GetArcTts();
On 2016/07/26 22:48:11, Luis Héctor Chávez wrote:
> DCHECK_CURRENTLY_ON(BrowserThread::UI);

Done.

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
File components/arc/tts/arc_tts_service.cc (right):

https://codereview.chromium.org/2180263002/diff/1/components/arc/tts/arc_tts_...
components/arc/tts/arc_tts_service.cc:49:
TtsController::GetInstance()->OnTtsEvent(id, chrome_event_type, 0, "");
On 2016/07/26 22:12:58, dmazzoni wrote:
> To match other engines, I think the "end" event should be sent with the
> utterance length as the char_index.

Passing this through now from the Android end.
> 
> You can install TTS Debug from the web store and it will run through a bunch
of
> manual and automated tests to make sure you've implemented a bunch of things
> correctly.
> 

Most of the logic is on the Android end. I suspect there will be some issues
with feature parity. Hoping to get the basic bindings in place first to avoid
constant rebasing.

https://codereview.chromium.org/2180263002/diff/60001/chrome/browser/speech/t...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/60001/chrome/browser/speech/t...
chrome/browser/speech/tts_chromeos.cc:119: if (tts_instance && tts_instance !=
last_tts_instance_) {
On 2016/07/29 09:25:53, hidehiko wrote:
> This does not work.
> E.g.; tts_instance is destructed once, and recreated at the same memory
> location.
> 
> Please make a standalone class, and observe OnInstance{Ready,Close}().
> Also, please let keep the instance track by ArcServiceManager. The instance
> should be added in arc_service_launcher.cc.

This was all fallout of trying to keep the service in compoents/arc. Deleted.

https://codereview.chromium.org/2180263002/diff/60001/components/arc/common/a...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/60001/components/arc/common/a...
components/arc/common/arc_bridge.mojom:95: [MinVersion=16]
OnTtsInstanceReady@123(TtsInstance instance_ptr);
On 2016/07/29 09:25:53, hidehiko wrote:
> Indent.

Done.

https://codereview.chromium.org/2180263002/diff/60001/components/arc/tts/arc_...
File components/arc/tts/arc_tts_service.h (right):

https://codereview.chromium.org/2180263002/diff/60001/components/arc/tts/arc_...
components/arc/tts/arc_tts_service.h:17: class ArcTtsService : public
ArcService,
On 2016/07/29 09:25:53, hidehiko wrote:
> This is no longer needed here. Instead you'll need to create another service
in
> chrome/browser/chromeos/arc/

Sorry; yes, this was actually all that was needed to address the deps issue in
patchset 1. Moved.

[Luis Héctor Chávez, 2016-08-01 20:29:53]

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
File components/arc/common/tts.mojom (right):

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
components/arc/common/tts.mojom:17: [Extensible]
structs are always extensible, so this attribute is not needed.

[hidehiko, 2016-08-02 03:56:19]

hidehiko@chromium.org changed reviewers:
+ rickyz@chromium.org

[hidehiko, 2016-08-02 03:56:20]

+rickyz@ for components/arc/common OWNER review. PTAL?

LGTM for */arc/* with minor comments. Defer to other reviewers.

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/arc/arc_tts_service.h (right):

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/arc/arc_tts_service.h:18: class ArcTtsService : public
ArcService,
Could you add brief comment about what is the responsibility of this class?

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/speech/...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/speech/...
chrome/browser/speech/tts_chromeos.cc:13: // Helper returning an Arc tts
instance.
nit: s/Arc/ARC/ in comment for consistency.

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
components/arc/common/arc_bridge.mojom:95: [MinVersion=16]
OnTtsInstanceReady@123(TtsInstance instance_ptr);
Please fix the indent.

[rickyz (no longer on Chrome), 2016-08-02 04:04:08]

mojom lgtm

[David Tseng, 2016-08-02 16:32:19]

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/arc/arc_tts_service.h (right):

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/arc/arc_tts_service.h:18: class ArcTtsService : public
ArcService,
On 2016/08/02 03:56:20, hidehiko wrote:
> Could you add brief comment about what is the responsibility of this class?

Done.

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/speech/...
File chrome/browser/speech/tts_chromeos.cc (right):

https://codereview.chromium.org/2180263002/diff/100001/chrome/browser/speech/...
chrome/browser/speech/tts_chromeos.cc:13: // Helper returning an Arc tts
instance.
On 2016/08/02 03:56:20, hidehiko wrote:
> nit: s/Arc/ARC/ in comment for consistency.

Done.

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
components/arc/common/arc_bridge.mojom:95: [MinVersion=16]
OnTtsInstanceReady@123(TtsInstance instance_ptr);
On 2016/08/02 03:56:20, hidehiko wrote:
> Please fix the indent.

Done.

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
File components/arc/common/tts.mojom (right):

https://codereview.chromium.org/2180263002/diff/100001/components/arc/common/...
components/arc/common/tts.mojom:17: [Extensible]
On 2016/08/01 20:29:53, Luis Héctor Chávez wrote:
> structs are always extensible, so this attribute is not needed.

Done.

[hidehiko, 2016-08-02 16:36:41]

BTW, could you run trybots, too?

https://codereview.chromium.org/2180263002/diff/120001/components/arc/common/...
File components/arc/common/arc_bridge.mojom (right):

https://codereview.chromium.org/2180263002/diff/120001/components/arc/common/...
components/arc/common/arc_bridge.mojom:95: [MinVersion=16] OnTt 
sInstanceReady@123(TtsInstance instance_ptr);
Looks wrong fix?

[David Tseng, 2016-08-02 16:37:29]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 16:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 16:49:24]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[David Tseng, 2016-08-02 17:13:12]

Patchset #7 (id:120001) has been deleted

[David Tseng, 2016-08-02 17:13:34]

Patchset #7 (id:140001) has been deleted

[David Tseng, 2016-08-02 17:15:13]

On 2016/08/02 16:36:41, hidehiko wrote:
> BTW, could you run trybots, too?
> 
>
https://codereview.chromium.org/2180263002/diff/120001/components/arc/common/...
> File components/arc/common/arc_bridge.mojom (right):
> 
>
https://codereview.chromium.org/2180263002/diff/120001/components/arc/common/...
> components/arc/common/arc_bridge.mojom:95: [MinVersion=16] OnTt 
> sInstanceReady@123(TtsInstance instance_ptr);
> Looks wrong fix?

Sorry; yes, fixed.

[hidehiko, 2016-08-02 17:33:45]

lgtm

[David Tseng, 2016-08-02 17:49:43]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-08-02 19:10:34]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-02 19:10:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2180263002/#ps160001
(title: "Address last round.")

[commit-bot: I haz the power, 2016-08-02 19:11:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:21:57]

Description was changed from

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed speak calls
through ChromeVox. Make adjustments in rate and pitch through the possible
ranges (0 to 5.0) and observe expected changes. Do this for multiple engines
from the Play Store.
==========

to

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed speak calls
through ChromeVox. Make adjustments in rate and pitch through the possible
ranges (0 to 5.0) and observe expected changes. Do this for multiple engines
from the Play Store.
==========

[commit-bot: I haz the power, 2016-08-02 19:21:59]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-08-02 19:23:17]

Description was changed from

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used. 

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed speak calls
through ChromeVox. Make adjustments in rate and pitch through the possible
ranges (0 to 5.0) and observe expected changes. Do this for multiple engines
from the Play Store.
==========

to

==========
Host side implementation of ARC tts.

This cl exposes ARC tts as a single voice through the Chrome tts api. Since ARC
tts engines can and do manage their own voices, it is left to the user to pick a
system voice inside of ARC. This also mitigates the issue of multiple tts
engines speaking at once which can also occur if two separate ARC tts engines
are used.

BUG=628963
TEST=build both sides and exercise tts features including start, end,
interrupted, error events. In addition, observe queued and flushed speak calls
through ChromeVox. Make adjustments in rate and pitch through the possible
ranges (0 to 5.0) and observe expected changes. Do this for multiple engines
from the Play Store.

Committed: https://crrev.com/9ea8fa35f638c4be2d32196e20348d3f05112a93
Cr-Commit-Position: refs/heads/master@{#409267}
==========

[commit-bot: I haz the power, 2016-08-02 19:23:18]

Patchset 7 (id:??) landed as
https://crrev.com/9ea8fa35f638c4be2d32196e20348d3f05112a93
Cr-Commit-Position: refs/heads/master@{#409267}