Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: webkit/glue/devtools/js/debugger_agent.js

Issue 218026: DevTools: autoresume execution on parse errors. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/devtools/script_syntax_error.html ('k') | webkit/glue/devtools/js/tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/devtools/js/debugger_agent.js
===================================================================
--- webkit/glue/devtools/js/debugger_agent.js (revision 27065)
+++ webkit/glue/devtools/js/debugger_agent.js (working copy)
@@ -790,8 +790,9 @@
WebInspector.currentPanel = WebInspector.panels.scripts;
var body = msg.getBody();
- if (this.pauseOnExceptions_) {
- var body = msg.getBody();
+ // No script field in the body means that v8 failed to parse the script. We
+ // resume execution on parser errors automatically.
+ if (this.pauseOnExceptions_ && body.script) {
Søren Thygesen Gjesse 2009/09/25 06:28:46 The assumption that if there is no script informat
yurys 2009/09/25 14:01:56 Are there other cases when body.script is undefine
var line = devtools.DebuggerAgent.v8ToWwebkitLineNumber_(body.sourceLine);
this.createExceptionMessage_(body.script.name, line, body.exception.text);
this.requestBacktrace_();
« no previous file with comments | « chrome/test/data/devtools/script_syntax_error.html ('k') | webkit/glue/devtools/js/tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698