DevTools: autoresume execution on parse errors.

webkit/glue/devtools/js/debugger_agent.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides communication interface to remote v8 debugger. See
  * protocol decription at http://code.google.com/p/v8/wiki/DebuggerProtocol
  */
 goog.provide('devtools.DebuggerAgent');
 
@@ skipping 772 matching lines @@
 
 
 /**
  * @param {devtools.DebuggerMessage} msg
  */
 devtools.DebuggerAgent.prototype.handleExceptionEvent_ = function(msg) {
   // Force scrips panel to be shown first.
   WebInspector.currentPanel = WebInspector.panels.scripts;
 
   var body = msg.getBody();
-  if (this.pauseOnExceptions_) {
-    var body = msg.getBody();
+  // No script field in the body means that v8 failed to parse the script. We
+  // resume execution on parser errors automatically.
+  if (this.pauseOnExceptions_ && body.script) {

[Søren Thygesen Gjesse, 2009/09/25 06:28:46]

The assumption that if there is no script information then it is a parsing error
seems fragile. Changes to V8 might break that. I think we should aim for adding
information to the exception event which will make this check more robust.

[yurys, 2009/09/25 14:01:56]

Are there other cases when body.script is undefined except parsing errors or we
can just add something like body.isParsingError flag?

     var line = devtools.DebuggerAgent.v8ToWwebkitLineNumber_(body.sourceLine);
     this.createExceptionMessage_(body.script.name, line, body.exception.text);
     this.requestBacktrace_();
   } else {
     this.resumeExecution();
   }
 };
 
 
 /**
@@ skipping 668 matching lines @@
 
 
 /**
  * @param {number} handle Object handle.
  * @return {?Object} Returns the object with the handle if it was sent in this
  *    message(some objects referenced by handles may be missing in the message).
  */
 devtools.DebuggerMessage.prototype.lookup = function(handle) {
   return this.refs_[handle];
 };