Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2180243002: Convert video-[in, throttled, useragent]* http tests to testharness.js (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-[in, throttled, useragent]* http tests to testharness.js Cleaning up video-[in, throttled, useragent]* http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/7acbd02bf2b0a50528e70fff2f9616661aafd12a Cr-Commit-Position: refs/heads/master@{#408069}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 10 (5 generated)
Srirama
PTAL https://codereview.chromium.org/2180243002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html File third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html (right): https://codereview.chromium.org/2180243002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html#newcode14 third_party/WebKit/LayoutTests/http/tests/media/video-in-iframe-crash.html:14: setTimeout(t.step_func(function() { Thought of using iframe.onload but then ...
4 years, 4 months ago (2016-07-26 13:29:30 UTC) #3
fs
lgtm
4 years, 4 months ago (2016-07-26 16:04:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180243002/1
4 years, 4 months ago (2016-07-27 04:47:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 07:12:36 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 07:15:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7acbd02bf2b0a50528e70fff2f9616661aafd12a
Cr-Commit-Position: refs/heads/master@{#408069}

Powered by Google App Engine
This is Rietveld 408576698