Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 218013002: Revert 260298 "Revert 260222 "Separate audio player tests from s..." (Closed)

Created:
6 years, 8 months ago by Charlie Reis
Modified:
6 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 260298 "Revert 260222 "Separate audio player tests from s..." Undoing the revert, since MultiProfileFileManagerBrowserTest failure was caused by Blink 170311 instead. Sorry for the disruption. > Revert 260222 "Separate audio player tests from special file tes..." > > Still trying to track down cause of MultiProfileFileManagerBrowserTest failures: > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22674 > > > > Separate audio player tests from special file test of Files.app (2nd) > > > > I have a plan to add more audio player tests. Before that, make audio player tests > > separated for readability. > > > > This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069. > > > > BUG=none > > TEST=browser_test passes > > TBR=hirino@chromium.org > > > > Review URL: https://codereview.chromium.org/212123008 > > TBR=yoshiki@chromium.org > > Review URL: https://codereview.chromium.org/217743002 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
M trunk/src/chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js View 2 chunks +0 lines, -91 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Reis
6 years, 8 months ago (2014-03-29 01:03:42 UTC) #1
Charlie Reis
6 years, 8 months ago (2014-03-29 01:05:01 UTC) #2
Charlie Reis
6 years, 8 months ago (2014-03-29 01:05:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r260327.

Powered by Google App Engine
This is Rietveld 408576698