chrome/browser/ui/webui/offline_internals_ui.cc - Issue 2180113003: Make sure the Async test cases availabel today generate correct ClientID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline_internals_ui.cc

Issue 2180113003: Make sure the Async test cases availabel today generate correct ClientID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline_internals_ui.cc

diff --git a/chrome/browser/ui/webui/offline_internals_ui.cc b/chrome/browser/ui/webui/offline_internals_ui.cc

index c8e57eeb99b7911687fd750396bd44039770600f..b4ef79e7b16eebf199edf15d5179bca67ee72314 100644

--- a/chrome/browser/ui/webui/offline_internals_ui.cc

+++ b/chrome/browser/ui/webui/offline_internals_ui.cc

@@ -9,6 +9,7 @@

#include <vector>

#include "base/bind.h"

+#include "base/guid.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string_number_conversions.h"

@@ -336,8 +337,10 @@ void OfflineInternalsUIMessageHandler::HandleAddToRequestQueue(

std::string url;

CHECK(args->GetString(1, &url));

+ // To be visible in Downloads UI, these items need a well-formed GUILD

chili 2016/07/27 18:40:47 nit: should this say "GUI ID"? or "GUID"?

Dmitry Titov 2016/07/27 19:50:49 Done.

+ // and AsyncNamespace in their ClientId.

std::ostringstream id_stream;

- id_stream << std::rand();

+ id_stream << base::GenerateGUID();

ResolveJavascriptCallback(

*callback_id,