Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2180063002: Reland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (Closed)

Created:
4 years, 5 months ago by mmenke
Modified:
4 years, 5 months ago
Reviewers:
eroman, Mark P
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #1 id:1 of https://codereview.chromium.org/2183433003/ ) Reason for revert: The CL was blamed for compile failures it didn't cause, re-landing. Original issue's description: > Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ ) > > Reason for revert: > Speculative revert for bug 631246. Have no better ideas. > > Apologies if this wasn't the cause. > > Original issue's description: > > HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. > > > > We were using HexStringToInt to parse chunk size, which returns a > > 32-bit int. This CL switches to using HexStringToInt64, which uses > > 64-bit ints, so we can now support chunks up to 2^63-1 bytes. > > > > That should be enough for anybody. [Cue dramatic music] > > > > BUG=630680 > > > > Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503 > > Cr-Commit-Position: refs/heads/master@{#407549} > > TBR=eroman@chromium.org,mmenke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=630680 > > Committed: https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591 > Cr-Commit-Position: refs/heads/master@{#407651} TBR=eroman@chromium.org,mpearson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630680 Committed: https://crrev.com/3fca2b4fdb391fa3c14386af8b72fc2092657029 Cr-Commit-Position: refs/heads/master@{#407700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -20 lines) Patch
M net/http/http_chunked_decoder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/http_chunked_decoder.cc View 6 chunks +19 lines, -14 lines 0 comments Download
M net/http/http_chunked_decoder_unittest.cc View 2 chunks +68 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Created Reland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
4 years, 5 months ago (2016-07-26 04:00:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180063002/1
4 years, 5 months ago (2016-07-26 04:01:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 04:02:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3fca2b4fdb391fa3c14386af8b72fc2092657029 Cr-Commit-Position: refs/heads/master@{#407700}
4 years, 5 months ago (2016-07-26 04:04:18 UTC) #6
Mark P
4 years, 5 months ago (2016-07-26 04:15:18 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698