DescriptionReland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #1 id:1 of https://codereview.chromium.org/2183433003/ )
Reason for revert:
The CL was blamed for compile failures it didn't cause, re-landing.
Original issue's description:
> Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ )
>
> Reason for revert:
> Speculative revert for bug 631246. Have no better ideas.
>
> Apologies if this wasn't the cause.
>
> Original issue's description:
> > HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
> >
> > We were using HexStringToInt to parse chunk size, which returns a
> > 32-bit int. This CL switches to using HexStringToInt64, which uses
> > 64-bit ints, so we can now support chunks up to 2^63-1 bytes.
> >
> > That should be enough for anybody. [Cue dramatic music]
> >
> > BUG=630680
> >
> > Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503
> > Cr-Commit-Position: refs/heads/master@{#407549}
>
> TBR=eroman@chromium.org,mmenke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630680
>
> Committed: https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591
> Cr-Commit-Position: refs/heads/master@{#407651}
TBR=eroman@chromium.org,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630680
Committed: https://crrev.com/3fca2b4fdb391fa3c14386af8b72fc2092657029
Cr-Commit-Position: refs/heads/master@{#407700}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|