Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2180033002: Make normal MD text buttons white. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make normal MD text buttons white. BUG=629658 Committed: https://crrev.com/886005cc219d728016d264cc3c97ceffcf1bf5a2 Cr-Commit-Position: refs/heads/master@{#407887}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/button/md_text_button.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 5 months ago (2016-07-26 00:23:36 UTC) #2
sky
LGTM https://codereview.chromium.org/2180033002/diff/1/ui/views/controls/button/md_text_button.cc File ui/views/controls/button/md_text_button.cc (right): https://codereview.chromium.org/2180033002/diff/1/ui/views/controls/button/md_text_button.cc#newcode268 ui/views/controls/button/md_text_button.cc:268: : is_default() Holy ternary operators Batman!
4 years, 4 months ago (2016-07-26 13:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180033002/1
4 years, 4 months ago (2016-07-26 17:06:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225302) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 19:07:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180033002/1
4 years, 4 months ago (2016-07-26 19:17:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 19:58:13 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:01:41 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/886005cc219d728016d264cc3c97ceffcf1bf5a2
Cr-Commit-Position: refs/heads/master@{#407887}

Powered by Google App Engine
This is Rietveld 408576698