chrome/browser/dom_ui/history_ui.h - Issue 218001: BrowsingDataRemover* should not be scoped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/history_ui.h

Issue 218001: BrowsingDataRemover* should not be scoped. (Closed)

Patch Set: Make BrowsingDataRemover destructor private Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/dom_ui/history_ui.h

diff --git a/chrome/browser/dom_ui/history_ui.h b/chrome/browser/dom_ui/history_ui.h

index 48b055baa3d935259efb1a6ae57650c1a84733c6..846fa6162a29991a9cbcaef8d71fede7d959402e 100644

--- a/chrome/browser/dom_ui/history_ui.h

+++ b/chrome/browser/dom_ui/history_ui.h

@@ -7,7 +7,6 @@

#include <vector>

-#include "base/scoped_ptr.h"

#include "chrome/browser/browsing_data_remover.h"

#include "chrome/browser/dom_ui/chrome_url_data_manager.h"

#include "chrome/browser/dom_ui/dom_ui.h"

@@ -80,7 +79,7 @@ class BrowsingHistoryHandler : public DOMMessageHandler,

std::wstring search_text_;

// Browsing history remover

- scoped_ptr<BrowsingDataRemover> remover_;

+ BrowsingDataRemover* remover_;

// Our consumer for the history service.

CancelableRequestConsumerT<int, 0> cancelable_consumer_;

« no previous file with comments | « chrome/browser/browsing_data_remover.h ('k') | chrome/browser/dom_ui/history_ui.cc » ('j') | no next file with comments »