Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 218001: BrowsingDataRemover* should not be scoped. (Closed)

Created:
11 years, 3 months ago by kuchhal
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy, brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

BrowsingDataRemover* should not be scoped. BrowsingDataRemover deletes itself (see browsing_data_remover.cc: MessageLoop::current()->DeleteSoon(FROM_HERE, this)). BUG=22068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27607

Patch Set 1 #

Patch Set 2 : Make BrowsingDataRemover destructor private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/browsing_data_remover.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kuchhal
I don't think this will fix the crash in 22068 but I found this while ...
11 years, 3 months ago (2009-09-23 01:05:39 UTC) #1
kuchhal
ping.
11 years, 3 months ago (2009-09-24 21:29:29 UTC) #2
kuchhal
Brett, I sent this to Glen originally but he is OOO. Can you take a ...
11 years, 2 months ago (2009-09-28 21:29:57 UTC) #3
brettw
In this case, it seems like BrowsingDataRemover's destructor should be private to avoid similar problems. ...
11 years, 2 months ago (2009-09-28 21:46:39 UTC) #4
kuchhal
Done. Please take another look.
11 years, 2 months ago (2009-09-28 23:14:44 UTC) #5
brettw
11 years, 2 months ago (2009-09-28 23:51:53 UTC) #6
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698