Issue 218001: BrowsingDataRemover* should not be scoped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218001: BrowsingDataRemover* should not be scoped. (Closed)

Created:
11 years, 3 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, brettw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

BrowsingDataRemover* should not be scoped. BrowsingDataRemover deletes itself (see browsing_data_remover.cc: MessageLoop::current()->DeleteSoon(FROM_HERE, this)). BUG=22068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27607

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	chrome/browser/browsing_data_remover.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/history_ui.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

kuchhal

I don't think this will fix the crash in 22068 but I found this while ...

11 years, 3 months ago (2009-09-23 01:05:39 UTC) #1

kuchhal

Brett, I sent this to Glen originally but he is OOO. Can you take a ...

11 years, 2 months ago (2009-09-28 21:29:57 UTC) #3

brettw

In this case, it seems like BrowsingDataRemover's destructor should be private to avoid similar problems. ...

11 years, 2 months ago (2009-09-28 21:46:39 UTC) #4

LGTM, thanks.