Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2179963003: LogDog/Butler: Prefer overridden stream name. (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog/Butler: Prefer overridden stream name. BUG=chromium:631232 TEST=local - `./logdog/client/cmd/logdog_butler -project asdf -output log stream -source test.cfg -stream name=test_stream` had stream name "test_stream". Committed: https://github.com/luci/luci-go/commit/cbf0e97aac311593a4ccf1cc20c12497097e2fbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M logdog/client/cmd/logdog_butler/subcommand_stream.go View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dnj
PTAL
4 years, 5 months ago (2016-07-25 22:52:29 UTC) #2
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-25 23:00:06 UTC) #3
nicholaslin
On 2016/07/25 22:52:29, dnj wrote: > PTAL lgtm
4 years, 5 months ago (2016-07-25 23:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179963003/1
4 years, 5 months ago (2016-07-25 23:01:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 23:12:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/cbf0e97aac311593a4ccf1cc20c12497097e2fbf

Powered by Google App Engine
This is Rietveld 408576698