Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2179953002: Remove FX_FONTCACHE_DEFINE (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_FONTCACHE_DEFINE This macro isn't buying us anything and reduces transparency. Committed: https://pdfium.googlesource.com/pdfium/+/22b05fc0f0cbfd3841b0963b577719fd16725081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxge/include/fx_font.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
dsinclair, for review.
4 years, 5 months ago (2016-07-25 20:17:58 UTC) #3
dsinclair
lgtm
4 years, 5 months ago (2016-07-25 20:24:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179953002/1
4 years, 5 months ago (2016-07-25 20:24:43 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 20:40:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/22b05fc0f0cbfd3841b0963b577719fd1672...

Powered by Google App Engine
This is Rietveld 408576698