Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2179943007: Remove duplicated lines in Android Build Instruction (Closed)

Created:
4 years, 4 months ago by amoseui
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, newt (away), brajkumar
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated lines in Android Build Instruction In GN args example of Android Build Instruction, 'symbol_level' and 'enable_incremental_javac' options are duplicated. BUG=632028 Committed: https://crrev.com/37fe7f5ad68ac9e5111f150e2c593b9ffebe2be6 Cr-Commit-Position: refs/heads/master@{#418067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M docs/android_build_instructions.md View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
amoseui
4 years, 4 months ago (2016-07-27 16:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179943007/1
4 years, 4 months ago (2016-08-19 11:31:02 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-19 11:31:04 UTC) #9
amoseui
4 years, 4 months ago (2016-08-19 11:33:24 UTC) #11
Dirk Pranke
Hi, Sorry for the delay on this, it fell through the cracks for me. The ...
4 years, 3 months ago (2016-08-31 23:42:35 UTC) #12
amoseui
On 2016/08/31 23:42:35, Dirk Pranke wrote: > Hi, > > Sorry for the delay on ...
4 years, 3 months ago (2016-09-05 09:41:21 UTC) #13
Dirk Pranke
LGTM now, thanks.
4 years, 3 months ago (2016-09-12 21:05:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179943007/1
4 years, 3 months ago (2016-09-12 21:06:08 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 21:55:41 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:58:09 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37fe7f5ad68ac9e5111f150e2c593b9ffebe2be6
Cr-Commit-Position: refs/heads/master@{#418067}

Powered by Google App Engine
This is Rietveld 408576698