Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2179943006: Fix a hidden crash when ImeThread feature is used (Closed)

Created:
4 years, 4 months ago by Changwan Ryu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a hidden crash when ImeThread feature is used DCHECK in PlainTextRange's constructor causes a crash when start > end, but the test passes, probably because it's a renderer crash and we call it at the end. In this case, we'll swap start and end just like BaseInputConnection does. Also adds some tests to fix the behavior and prevents a crash in the future. BUG= Committed: https://crrev.com/d7e40d40a011ad58385e8935764898bdde795aa2 Cr-Commit-Position: refs/heads/master@{#408927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +5 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Changwan Ryu
I've encountered this while fixing something else. PTAL.
4 years, 4 months ago (2016-07-27 08:08:21 UTC) #4
Changwan Ryu
On 2016/07/27 08:08:21, Changwan Ryu wrote: > I've encountered this while fixing something else. PTAL. ...
4 years, 4 months ago (2016-08-01 05:36:52 UTC) #7
yabinh
lgtm
4 years, 4 months ago (2016-08-01 06:33:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179943006/1
4 years, 4 months ago (2016-08-01 06:54:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 07:57:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 08:00:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7e40d40a011ad58385e8935764898bdde795aa2
Cr-Commit-Position: refs/heads/master@{#408927}

Powered by Google App Engine
This is Rietveld 408576698