Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2179943004: Set the RTP payload type to fixed values for audio/video streams. (Closed)

Created:
4 years, 4 months ago by xjz
Modified:
4 years, 4 months ago
Reviewers:
miu
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the RTP payload type to fixed values for audio/video streams. Fugu receivers expect specific RTP payload type for audio/video streams. This constraint should be removed from receiver codes. For now, sender will override the payload type with the required value in each RTP packet. BUG=631828 Committed: https://crrev.com/cae9d55680876b8c22acdd6c3e3cd38a57d7fc14 Cr-Commit-Position: refs/heads/master@{#408038}

Patch Set 1 #

Patch Set 2 : Fix chromium receiver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M media/cast/net/rtp/rtp_sender.cc View 1 chunk +8 lines, -1 line 0 comments Download
M media/cast/receiver/frame_receiver.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
xjz
PTAL
4 years, 4 months ago (2016-07-26 23:14:22 UTC) #4
miu
lgtm
4 years, 4 months ago (2016-07-26 23:33:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179943004/20001
4 years, 4 months ago (2016-07-27 04:18:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 04:21:27 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 04:22:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cae9d55680876b8c22acdd6c3e3cd38a57d7fc14
Cr-Commit-Position: refs/heads/master@{#408038}

Powered by Google App Engine
This is Rietveld 408576698