Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2179943002: Remove isInternalFlag from V8ScriptRunner interface in blink (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
haraken, dgozman
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isInternalFlag from V8ScriptRunner interface in blink isInternalFlag is used by DevTools internally and we don't need to expose it to public blink API. BUG=none R=haraken@chromium.org,dgozman@chromium.org Committed: https://crrev.com/8ec9291e0243a14655e302232607e81fa5eded26 Cr-Commit-Position: refs/heads/master@{#407624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kozy
@haraken and @dgozman, please take a look. Scripts are compiling with isInternalFlag in blink in ...
4 years, 5 months ago (2016-07-25 20:17:05 UTC) #1
haraken
LGTM
4 years, 5 months ago (2016-07-25 20:18:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179943002/1
4 years, 5 months ago (2016-07-25 20:20:51 UTC) #4
dgozman
lgtm
4 years, 5 months ago (2016-07-25 20:28:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 23:03:49 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 23:07:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ec9291e0243a14655e302232607e81fa5eded26
Cr-Commit-Position: refs/heads/master@{#407624}

Powered by Google App Engine
This is Rietveld 408576698