Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 2179923002: Add a JavaScript dialog tab helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/tab_helpers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
index a58e021b4ba8fe95482c2d568067581fc057d036..ec912c598cff72767c0e9055bffb94bdf2f504c3 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
@@ -214,7 +214,7 @@ content::JavaScriptDialogManager*
MimeHandlerViewGuest::GetJavaScriptDialogManager(
WebContents* source) {
return owner_web_contents()->GetDelegate()->GetJavaScriptDialogManager(
- web_contents());
+ owner_web_contents());
raymes 2016/09/01 01:28:30 Could you explain why you've changed this? Thanks!
Avi (use Gerrit) 2016/09/01 01:38:02 Rather than having a single manager globally, I wa
paulmeyer 2016/09/01 15:45:53 Nit: Could you please add a short comment here to
}
bool MimeHandlerViewGuest::SaveFrame(const GURL& url,
« no previous file with comments | « chrome/browser/ui/tab_helpers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698