Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2179923002: Add a JavaScript dialog tab helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 1483086b6b6a9d376179aaaec451182febddf6d5..fd525b7866cc3953a1a958303ad770a03c650f5a 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -122,6 +122,7 @@
#include "chrome/browser/ui/global_error/global_error.h"
#include "chrome/browser/ui/global_error/global_error_service.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
+#include "chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h"
#include "chrome/browser/ui/location_bar/location_bar.h"
#include "chrome/browser/ui/media_utils.h"
#include "chrome/browser/ui/search/search_delegate.h"
@@ -156,7 +157,6 @@
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/locale_settings.h"
-#include "components/app_modal/javascript_dialog_manager.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h"
#include "components/bookmarks/common/bookmark_pref_names.h"
@@ -1639,7 +1639,7 @@ void Browser::DidNavigateMainFramePostCommit(WebContents* web_contents) {
content::JavaScriptDialogManager* Browser::GetJavaScriptDialogManager(
WebContents* source) {
- return app_modal::JavaScriptDialogManager::GetInstance();
+ return JavaScriptDialogTabHelper::FromWebContents(source);
}
content::ColorChooser* Browser::OpenColorChooser(
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698