Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/extensions/content_script_apitest.cc

Issue 2179923002: Add a JavaScript dialog tab helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/content_script_apitest.cc
diff --git a/chrome/browser/extensions/content_script_apitest.cc b/chrome/browser/extensions/content_script_apitest.cc
index 126beb51e6cb024bf68142397e4e663a40688c9c..4615de0ac247ce6edd891f1b8a49fd136b1bdaa5 100644
--- a/chrome/browser/extensions/content_script_apitest.cc
+++ b/chrome/browser/extensions/content_script_apitest.cc
@@ -164,12 +164,11 @@ DialogHelper::DialogHelper(content::WebContents* web_contents)
client_(nullptr) {
app_modal::JavaScriptDialogManager* dialog_manager_impl =
app_modal::JavaScriptDialogManager::GetInstance();
- dialog_manager_ =
- web_contents_->GetDelegate()->GetJavaScriptDialogManager(web_contents_);
- DCHECK_EQ(dialog_manager_impl, dialog_manager_);
-
client_ = new DialogClient(this);
dialog_manager_impl->SetExtensionsClient(base::WrapUnique(client_));
+
+ dialog_manager_ =
+ web_contents_->GetDelegate()->GetJavaScriptDialogManager(web_contents_);
}
DialogHelper::~DialogHelper() {
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698