Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2179913002: Make compositing/canvas-with-object-fit-contain-in-composited-layer.html less flaky (Closed)

Created:
4 years, 4 months ago by Justin Novosad
Modified:
4 years, 4 months ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make compositing/canvas-with-object-fit-contain-in-composited-layer.html less flaky Modified layout test to make it less sensitive to anti-aliasing/blending precision issues to prevent bogus flakiness. BUG=628266 Committed: https://crrev.com/74479a00220864f48aaaa78ac0e12c78aaa5e9fd Cr-Commit-Position: refs/heads/master@{#407558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer.html View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/canvas-with-object-fit-contain-in-composited-layer-expected.html View 1 chunk +5 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Justin Novosad
PTAL
4 years, 4 months ago (2016-07-25 18:54:51 UTC) #3
xidachen
lgtm
4 years, 4 months ago (2016-07-25 19:14:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179913002/1
4 years, 4 months ago (2016-07-25 19:21:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 20:14:11 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 20:17:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74479a00220864f48aaaa78ac0e12c78aaa5e9fd
Cr-Commit-Position: refs/heads/master@{#407558}

Powered by Google App Engine
This is Rietveld 408576698