Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2179903009: Reverting bad fix of issue #26941. (Closed)

Created:
4 years, 4 months ago by regis
Modified:
4 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M runtime/vm/parser.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
TBR This change may have fixed #26941, but it is not correct and actually worse ...
4 years, 4 months ago (2016-07-28 19:38:40 UTC) #2
regis
Committed patchset #1 (id:1) manually as 48060a653f2af5979609051d99e933bd093a38f2 (presubmit successful).
4 years, 4 months ago (2016-07-28 19:39:55 UTC) #4
hausner
4 years, 4 months ago (2016-07-28 19:43:56 UTC) #5
Message was sent while issue was closed. 
LGTM.

The joy was short-lived :/

Powered by Google App Engine
This is Rietveld 408576698