Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2179903008: Don't call finish on GrDrawTarget if we drew no batches (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't call finish on GrDrawTarget if we drew no batches This might give us some minor perf gains in vulkan since we won't be submitting command buffers that we've added to batch draws to. Running nanobench this does seem to happen pretty often. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179903008 Committed: https://skia.googlesource.com/skia/+/b4021cfd6630dccc95ee1d4124cad41c79103129

Patch Set 1 #

Patch Set 2 : Move check to top of drawBatches #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 4 months ago (2016-07-28 14:02:25 UTC) #3
egdaniel
updated
4 years, 4 months ago (2016-07-28 14:31:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179903008/40001
4 years, 4 months ago (2016-07-28 14:31:25 UTC) #6
bsalomon
lgtm
4 years, 4 months ago (2016-07-28 14:49:57 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 15:53:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b4021cfd6630dccc95ee1d4124cad41c79103129

Powered by Google App Engine
This is Rietveld 408576698