Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/renderer/chrome_render_frame_observer.cc

Issue 2179903005: [Prerender] Change IPC from bool to enum for more prerender modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefetchProto
Patch Set: comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_render_frame_observer.h" 5 #include "chrome/renderer/chrome_render_frame_observer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <limits> 10 #include <limits>
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 OnPrintNodeUnderContextMenu) 154 OnPrintNodeUnderContextMenu)
155 #endif 155 #endif
156 IPC_MESSAGE_HANDLER(ChromeViewMsg_AppBannerPromptRequest, 156 IPC_MESSAGE_HANDLER(ChromeViewMsg_AppBannerPromptRequest,
157 OnAppBannerPromptRequest) 157 OnAppBannerPromptRequest)
158 IPC_MESSAGE_UNHANDLED(handled = false) 158 IPC_MESSAGE_UNHANDLED(handled = false)
159 IPC_END_MESSAGE_MAP() 159 IPC_END_MESSAGE_MAP()
160 160
161 return handled; 161 return handled;
162 } 162 }
163 163
164 void ChromeRenderFrameObserver::OnSetIsPrerendering(bool is_prerendering) { 164 void ChromeRenderFrameObserver::OnSetIsPrerendering(
165 if (is_prerendering) { 165 prerender::PrerenderMode mode) {
166 if (mode == prerender::FULL_PRERENDER) {
mattcary 2016/07/27 11:31:54 Should this be mode != NO_PRERENDER? I thought we
droger 2016/07/27 13:16:55 Good point, done.
166 // If the PrerenderHelper for this frame already exists, don't create it. It 167 // If the PrerenderHelper for this frame already exists, don't create it. It
167 // can already be created for subframes during handling of 168 // can already be created for subframes during handling of
168 // RenderFrameCreated, if the parent frame was prerendering at time of 169 // RenderFrameCreated, if the parent frame was prerendering at time of
169 // subframe creation. 170 // subframe creation.
170 if (prerender::PrerenderHelper::Get(render_frame())) 171 if (prerender::PrerenderHelper::Get(render_frame()))
171 return; 172 return;
172 173
173 // The PrerenderHelper will destroy itself either after recording histograms 174 // The PrerenderHelper will destroy itself either after recording histograms
174 // or on destruction of the RenderView. 175 // or on destruction of the RenderView.
175 new prerender::PrerenderHelper(render_frame()); 176 new prerender::PrerenderHelper(render_frame());
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 CapturePageText(FINAL_CAPTURE); 418 CapturePageText(FINAL_CAPTURE);
418 break; 419 break;
419 default: 420 default:
420 break; 421 break;
421 } 422 }
422 } 423 }
423 424
424 void ChromeRenderFrameObserver::OnDestruct() { 425 void ChromeRenderFrameObserver::OnDestruct() {
425 delete this; 426 delete this;
426 } 427 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698