Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: blimp/client/core/BUILD.gn

Issue 2179843005: Rename GN arg for enabling blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/client/public/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/BUILD.gn
diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn
index 5e3a3e9de24c0362a49ec4a82194f878183f8f9c..42e10c87665abb6e4ba464cccf7955653915d8d1 100644
--- a/blimp/client/core/BUILD.gn
+++ b/blimp/client/core/BUILD.gn
@@ -8,18 +8,19 @@ if (is_android) {
}
declare_args() {
- # Enables blimp. This is required to get the real implementation of blimp.
+ # Enables the blimp client. This is required to get the actual implementation
+ # of blimp.
# By default, only a dummy-implementation is provided.
- enable_blimp = false
+ enable_blimp_client = false
}
# This target is here to let //chrome depend on //blimp/client/public
# and automatically get the correct implementation of //blimp/client/core
-# depending on whether enable_blimp is set or not.
+# depending on whether enable_blimp_client is set or not.
group("core_shim") {
visibility = [ "//blimp/client/public" ]
- if (enable_blimp) {
+ if (enable_blimp_client) {
deps = [
":core",
]
@@ -125,12 +126,12 @@ source_set("switches") {
if (is_android) {
# This target is here to let //chrome depend on
# //blimp/client/public:public_java and automatically get the correct
- # implementation of //blimp/client/core depending on whether enable_blimp is
- # set or not.
+ # implementation of //blimp/client/core depending on whether
+ # enable_blimp_client is set or not.
java_group("core_shim_java") {
visibility = [ "//blimp/client/public/*" ]
- if (enable_blimp) {
+ if (enable_blimp_client) {
deps = [
":core_java",
]
« no previous file with comments | « no previous file | blimp/client/public/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698