Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2179843005: Rename GN arg for enabling blimp. (Closed)

Created:
4 years, 4 months ago by nyquist
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, maniscalco, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename GN arg for enabling blimp. Since the enable_blimp flag was only ever supposed to be used for the blimp client, this makes that abundandtly clear by renaming the GN arg itself. BUG=611094, 624025, 608765 Committed: https://crrev.com/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce Cr-Commit-Position: refs/heads/master@{#407956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M blimp/client/core/BUILD.gn View 2 chunks +8 lines, -7 lines 0 comments Download
M blimp/client/public/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M build/args/blimp_client.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
nyquist
dpranke: PTAL maniscalco: FYI amineer: FYI
4 years, 4 months ago (2016-07-26 21:32:03 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-26 22:03:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179843005/1
4 years, 4 months ago (2016-07-26 22:05:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 23:09:08 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:12:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b77fb9f0d01e24b04f8c48f05c7007f4f5c1dce
Cr-Commit-Position: refs/heads/master@{#407956}

Powered by Google App Engine
This is Rietveld 408576698