Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2179783003: Revert of DevTools: cleanup treeoutline expand logic (Closed)

Created:
4 years, 5 months ago by allada
Modified:
4 years, 4 months ago
Reviewers:
dgozman, lushnikov, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: cleanup treeoutline expand logic (patchset #1 id:1 of https://codereview.chromium.org/2147343002/ ) Reason for revert: [Devtools] Broke header tabs in network tab BUG=630971 Original issue's description: > DevTools: cleanup treeoutline expand logic > > TreeElement.expand() should not need to check that the element has children and > TreeOutline.insertChild() should not automatically expand a child when it is > inserted. ObjectPropertiesSection.js depended on this logic to automatically > expand the Entries property. This CL updates it so that the Entries property is > added before expanded. > > BUG= > > Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7 > Cr-Commit-Position: refs/heads/master@{#407061} TBR=lushnikov@chromium.org,luoe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
allada
Created Revert of DevTools: cleanup treeoutline expand logic
4 years, 5 months ago (2016-07-25 21:33:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179783003/1
4 years, 5 months ago (2016-07-25 21:34:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-25 21:34:28 UTC) #5
luoe
lgtm
4 years, 5 months ago (2016-07-25 21:35:58 UTC) #7
dgozman
rs lgtm
4 years, 5 months ago (2016-07-25 21:37:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179783003/1
4 years, 5 months ago (2016-07-25 21:38:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/40964) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-25 21:40:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179783003/1
4 years, 5 months ago (2016-07-25 21:55:46 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:57:38 UTC) #17
Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

Powered by Google App Engine
This is Rietveld 408576698