Use GTEST_LANG_CXX11 in V8

Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299
Committed: https://crrev.com/497e10bf654eade4bdb0b90d7e2d81897395148c
Cr-Commit-Position: refs/heads/master@{#38021}

[tzik, 2016-07-25 09:49:53]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 09:50:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 10:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 10:15:37]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-07-25 10:26:53]

Description was changed from

==========
Use GTEST_LANG_CXX11 in V8

BUG=
==========

to

==========
Use GTEST_LANG_CXX11 in V8

BUG=chromium:630299
==========

[tzik, 2016-07-25 10:28:17]

tzik@chromium.org changed reviewers:
+ machenbach@chromium.org

[tzik, 2016-07-25 10:28:18]

PTAL

[tzik, 2016-07-25 10:50:43]

Description was changed from

==========
Use GTEST_LANG_CXX11 in V8

BUG=chromium:630299
==========

to

==========
Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299
==========

[Michael Achenbach, 2016-07-25 12:51:47]

lgtm - rubberstamp - but I wonder, the failing bots on the roll all used GN and
this doesn't include any GN change, right?

[tzik, 2016-07-25 12:55:30]

On 2016/07/25 12:51:47, Michael Achenbach (slow) wrote:
> lgtm - rubberstamp - but I wonder, the failing bots on the roll all used GN
and
> this doesn't include any GN change, right?

The failing chrome //build roll contains a change to
//build/secondary/testing/gtest/BUILD.gn that flips GTEST_LANG_CXX11.
And the flag flip needs gmock-port.h that I'm adding.

[Michael Achenbach, 2016-07-25 13:04:54]

On 2016/07/25 12:55:30, tzik wrote:
> On 2016/07/25 12:51:47, Michael Achenbach (slow) wrote:
> > lgtm - rubberstamp - but I wonder, the failing bots on the roll all used GN
> and
> > this doesn't include any GN change, right?
> 
> The failing chrome //build roll contains a change to
> //build/secondary/testing/gtest/BUILD.gn that flips GTEST_LANG_CXX11.
> And the flag flip needs gmock-port.h that I'm adding.

SG. Thanks for fixing!

[Michael Achenbach, 2016-07-25 13:05:00]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-25 13:05:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 13:06:25]

Description was changed from

==========
Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299
==========

to

==========
Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299
==========

[commit-bot: I haz the power, 2016-07-25 13:06:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 13:06:50]

Description was changed from

==========
Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299
==========

to

==========
Use GTEST_LANG_CXX11 in V8

For GYP build, V8 configures gtest and gmock in its //testing, and OTOH for
GN build, it imports BUILD.gn from chromium and uses other configurations
from its own. However, a recent chromium change on the BUILD.gn requires
//testing update too. That prevents //build roll of V8.

BUG=chromium:630299

Committed: https://crrev.com/497e10bf654eade4bdb0b90d7e2d81897395148c
Cr-Commit-Position: refs/heads/master@{#38021}
==========

[commit-bot: I haz the power, 2016-07-25 13:06:51]

Patchset 1 (id:??) landed as
https://crrev.com/497e10bf654eade4bdb0b90d7e2d81897395148c
Cr-Commit-Position: refs/heads/master@{#38021}

[Michael Achenbach, 2016-07-25 14:00:42]

Fixed the issue: https://codereview.chromium.org/2178803003/ thanks!