Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2653)

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 2179713004: Deprecate FLAGS_quic_always_write_queued_retransmissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128171703
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager_interface.h ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager_test.cc
diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc
index b21d39e9a293e994d97e640883af15a54222ff81..c053a7d0b0646e6442926de93dbfdd6f7cfcfaf5 100644
--- a/net/quic/quic_sent_packet_manager_test.cc
+++ b/net/quic/quic_sent_packet_manager_test.cc
@@ -124,7 +124,8 @@ class QuicSentPacketManagerTest : public ::testing::TestWithParam<TestParams> {
EXPECT_TRUE(manager_.HasUnackedPackets());
EXPECT_EQ(packets[0], manager_.GetLeastUnacked(kDefaultPathId));
for (size_t i = 0; i < num_packets; ++i) {
- EXPECT_TRUE(manager_.IsUnacked(kDefaultPathId, packets[i])) << packets[i];
+ EXPECT_TRUE(QuicSentPacketManagerPeer::IsUnacked(&manager_, packets[i]))
+ << packets[i];
}
}
@@ -134,7 +135,8 @@ class QuicSentPacketManagerTest : public ::testing::TestWithParam<TestParams> {
num_packets,
QuicSentPacketManagerPeer::GetNumRetransmittablePackets(&manager_));
for (size_t i = 0; i < num_packets; ++i) {
- EXPECT_TRUE(manager_.HasRetransmittableFrames(kDefaultPathId, packets[i]))
+ EXPECT_TRUE(QuicSentPacketManagerPeer::HasRetransmittableFrames(
+ &manager_, packets[i]))
<< " packets[" << i << "]:" << packets[i];
}
}
@@ -590,7 +592,7 @@ TEST_P(QuicSentPacketManagerTest, AckPreviousTransmissionThenTruncatedAck) {
NackPackets(1, 2, &ack_frame);
ExpectAck(2);
manager_.OnIncomingAck(ack_frame, clock_.Now());
- EXPECT_TRUE(manager_.IsUnacked(kDefaultPathId, 4));
+ EXPECT_TRUE(QuicSentPacketManagerPeer::IsUnacked(&manager_, 4));
}
// Truncated ack with 4 NACKs
« no previous file with comments | « net/quic/quic_sent_packet_manager_interface.h ('k') | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698