Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2179673002: Clean up DevTools API docs following removal of old APIs (Closed)

Created:
4 years, 5 months ago by caseq
Modified:
4 years, 4 months ago
Reviewers:
paulirish, pfeldman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up DevTools API docs following removal of old APIs - remove docs for chrome.experimental.devtools.console - remove docs and sample for preprocessorScript option of chrome.devtools.inspectedWindow.reload() BUG=602063 Committed: https://crrev.com/12958cac9363bda657df3f79a8fa20430b2359a9 Cr-Commit-Position: refs/heads/master@{#408525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -445 lines) Patch
D chrome/common/extensions/api/devtools/experimental_console.json View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/common/extensions/api/devtools/inspected_window.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/InspectedWindowLoadMonitor.js View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.css View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/chrome-preprocessor.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/chrome-preprocessor.js View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
A + chrome/common/extensions/docs/templates/articles/experimental_devtools_console.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_network.html View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/experimental_devtools_console.html View 1 chunk +5 lines, -6 lines 0 comments Download
D chrome/common/extensions/docs/templates/public/extensions/experimental_devtools_console.html View 1 chunk +0 lines, -1 line 0 comments Download
D docs/script_preprocessor.md View 1 chunk +0 lines, -143 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
caseq
4 years, 5 months ago (2016-07-23 20:34:21 UTC) #2
pfeldman
lgtm
4 years, 5 months ago (2016-07-25 18:18:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179673002/1
4 years, 4 months ago (2016-07-28 16:11:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/227074)
4 years, 4 months ago (2016-07-28 16:17:12 UTC) #7
paulirish
lgtm
4 years, 4 months ago (2016-07-28 17:14:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179673002/1
4 years, 4 months ago (2016-07-28 23:43:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 00:07:44 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 00:11:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12958cac9363bda657df3f79a8fa20430b2359a9
Cr-Commit-Position: refs/heads/master@{#408525}

Powered by Google App Engine
This is Rietveld 408576698