Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2179633002: Fix GYP build for Chrome OS to match GN (Closed)

Created:
4 years, 5 months ago by skau
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, emircan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GYP build for Chrome OS to match GN Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc} Disable the cloud print connector like in GN in chrome.gyp Originally attempted as https://crrev.com/2170123003 BUG=630791 TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles Committed: https://crrev.com/04b30ad64d8a6309d81d9df9240250ae50d6a711 Cr-Commit-Position: refs/heads/master@{#407354}

Patch Set 1 #

Patch Set 2 : Reapply patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M printing/printing.gyp View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
skau
Sorry about the last CL, turns out that GYP conditions aren't exclusive.
4 years, 5 months ago (2016-07-23 03:10:23 UTC) #2
Lei Zhang
lgtm For relands, upload the reverted CL as patch set 1 and the fix as ...
4 years, 5 months ago (2016-07-23 04:31:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179633002/1
4 years, 5 months ago (2016-07-23 04:31:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 05:08:02 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 05:10:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b30ad64d8a6309d81d9df9240250ae50d6a711
Cr-Commit-Position: refs/heads/master@{#407354}

Powered by Google App Engine
This is Rietveld 408576698