Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2179593002: Warm up image cache for data URI used in tests (Closed)

Created:
4 years, 5 months ago by wychen
Modified:
4 years, 5 months ago
Reviewers:
mdjones, nyquist
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Warm up image cache for data URI used in tests The data URI for image tests were added in: https://codereview.chromium.org/1754213004/ It relies on sync loading of the images, which is no longer the case after https://codereview.chromium.org/2173003002/. R=nyquist@chromium.org Committed: 6c16f14405fdf4f4b4c90e9df2fb142e6951f84e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M war/test.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wychen
PTAL
4 years, 5 months ago (2016-07-22 18:59:14 UTC) #2
nyquist
lgtm
4 years, 5 months ago (2016-07-22 19:22:24 UTC) #3
wychen
4 years, 5 months ago (2016-07-22 22:24:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c16f14405fdf4f4b4c90e9df2fb142e6951f84e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698