chrome/browser/android/contextualsearch/contextual_search_manager.h - Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_manager.h

Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('k') | chrome/browser/android/contextualsearch/contextual_search_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/contextualsearch/contextual_search_manager.h

diff --git a/chrome/browser/android/contextualsearch/contextual_search_manager.h b/chrome/browser/android/contextualsearch/contextual_search_manager.h

index 4602efb23b13263c1178c0e5c416ac015b7d5078..6465a74cdc3be842ece838f0d6489812c4e458da 100644

--- a/chrome/browser/android/contextualsearch/contextual_search_manager.h

+++ b/chrome/browser/android/contextualsearch/contextual_search_manager.h

@@ -39,7 +39,7 @@ class ContextualSearchManager

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jstring>& j_selection,

jboolean j_use_resolved_search_term,

- const base::android::JavaParamRef<jobject>& j_base_content_view_core,

+ const base::android::JavaParamRef<jobject>& j_base_web_contents,

jboolean j_may_send_base_page_url);

// Gathers the surrounding text around the selection and saves it locally.

@@ -49,7 +49,7 @@ class ContextualSearchManager

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jstring>& j_selection,

jboolean j_use_resolved_search_term,

- const base::android::JavaParamRef<jobject>& j_base_content_view_core,

+ const base::android::JavaParamRef<jobject>& j_base_web_contents,

jboolean j_may_send_base_page_url);

// Gets the target language for translation purposes.

@@ -62,11 +62,11 @@ class ContextualSearchManager

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj);

- // Enables the Contextual Search JS API for the given |ContentViewCore|.

+ // Enables the Contextual Search JS API for the given |WebContents|.

void EnableContextualSearchJsApiForOverlay(

JNIEnv* env,

jobject obj,

- jobject j_overlay_content_view_core);

+ const base::android::JavaParamRef<jobject>& j_web_contents);

// ContextualSearchJsApiHandler overrides:

void SetCaption(std::string caption, bool does_answer) override;