chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java - Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/browser/android/compositor/tab_content_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

index 6e711b0769e3643dd8c875f4a66a87aeb124ecce..12266a17afaca866b671da2fed7c19269958f277 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

@@ -22,6 +22,7 @@ import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilterHos

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.ContextualSearchClient;

+import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.WindowAndroid;

import org.chromium.ui.resources.dynamics.DynamicResourceLoader;

import org.chromium.ui.touch_selection.SelectionEventType;

@@ -103,7 +104,7 @@ public class ContextualSearchTapEventTest extends ChromeActivityTestCaseBase<Chr

@Override

protected void nativeGatherSurroundingText(long nativeContextualSearchManager,

String selection, boolean useResolvedSearchTerm,

- ContentViewCore baseContentViewCore, boolean maySendBasePageUrl) {}

+ WebContents webContents, boolean maySendBasePageUrl) {}

/**

* @return A stubbed ContentViewCore for mocking text selection.