chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java - Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

index 587bd5d96161321d40e265056cb12f0395715a9d..3c79038b922ac923633f0af66e44695a37729e53 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

@@ -229,8 +229,8 @@ public class TabContentManager {

mThumbnailScale);

nativePageBitmap.recycle();

} else {

- nativeCacheTab(mNativeTabContentManager, tab, tab.getContentViewCore(),

- mThumbnailScale);

+ if (tab.getWebContents() == null) return;

+ nativeCacheTab(mNativeTabContentManager, tab, mThumbnailScale);

}

@@ -318,8 +318,8 @@ public class TabContentManager {

private native long nativeInit(int defaultCacheSize, int approximationCacheSize,

int compressionQueueMaxSize, int writeQueueMaxSize, boolean useApproximationThumbnail);

private native boolean nativeHasFullCachedThumbnail(long nativeTabContentManager, int tabId);

- private native void nativeCacheTab(long nativeTabContentManager, Object tab,

- Object contentViewCore, float thumbnailScale);

+ private native void nativeCacheTab(

+ long nativeTabContentManager, Object tab, float thumbnailScale);

private native void nativeCacheTabWithBitmap(long nativeTabContentManager, Object tab,

Object bitmap, float thumbnailScale);

private native void nativeInvalidateIfChanged(long nativeTabContentManager, int tabId,

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »