CrNet framework packaging script

CrNet framework packaging script

Committed: https://crrev.com/e4bcc542bf697b34f02250a7646fdb2da4a7f7a9
Cr-Commit-Position: refs/heads/master@{#407266}

[kapishnikov, 2016-07-22 17:48:09]

kapishnikov@chromium.org changed reviewers:
+ mef@chromium.org

[mef, 2016-07-22 19:47:06]

looks good mod icu option.

https://codereview.chromium.org/2179543002/diff/20001/components/cronet/tools...
File components/cronet/tools/package_ios.py (right):

https://codereview.chromium.org/2179543002/diff/20001/components/cronet/tools...
components/cronet/tools/package_ios.py:157: parser.add_argument('--use_icu',
action='store_true',
nit: this is confusing. Option is called 'use_icu' but means 'don't use icu'. Or
not?

[kapishnikov, 2016-07-22 20:20:24]

https://codereview.chromium.org/2179543002/diff/20001/components/cronet/tools...
File components/cronet/tools/package_ios.py (right):

https://codereview.chromium.org/2179543002/diff/20001/components/cronet/tools...
components/cronet/tools/package_ios.py:157: parser.add_argument('--use_icu',
action='store_true',
On 2016/07/22 19:47:06, mef wrote:
> nit: this is confusing. Option is called 'use_icu' but means 'don't use icu'.
Or
> not?

Changed the flag to 'use_full_icu" and changed the help doc.

[mef, 2016-07-22 20:30:00]

lgtm

https://codereview.chromium.org/2179543002/diff/40001/components/cronet/tools...
File components/cronet/tools/package_ios.py (right):

https://codereview.chromium.org/2179543002/diff/40001/components/cronet/tools...
components/cronet/tools/package_ios.py:172: use_platform_icu_alternatives =
'use_platform_icu_alternatives=0 ' \
nit: maybe rephrase it:

use_platform_icu_alternatives = 'use_platform_icu_alternatives=1' \
  if not options.use_full_icu else 'use_platform_icu_alternatives=0'

[kapishnikov, 2016-07-22 20:43:31]

On 2016/07/22 20:30:00, mef wrote:
> lgtm
> 
>
https://codereview.chromium.org/2179543002/diff/40001/components/cronet/tools...
> File components/cronet/tools/package_ios.py (right):
> 
>
https://codereview.chromium.org/2179543002/diff/40001/components/cronet/tools...
> components/cronet/tools/package_ios.py:172: use_platform_icu_alternatives =
> 'use_platform_icu_alternatives=0 ' \
> nit: maybe rephrase it:
> 
> use_platform_icu_alternatives = 'use_platform_icu_alternatives=1' \
>   if not options.use_full_icu else 'use_platform_icu_alternatives=0'

Done

[kapishnikov, 2016-07-22 20:43:47]

The CQ bit was checked by kapishnikov@chromium.org

[kapishnikov, 2016-07-22 20:43:47]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2179543002/#ps60001
(title: "Changed use_platform_icu_alternatives 'if' statement")

[commit-bot: I haz the power, 2016-07-22 20:44:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 21:33:39]

Description was changed from

==========
CrNet framework packaging script
==========

to

==========
CrNet framework packaging script

Committed: https://crrev.com/e4bcc542bf697b34f02250a7646fdb2da4a7f7a9
Cr-Commit-Position: refs/heads/master@{#407266}
==========

[commit-bot: I haz the power, 2016-07-22 21:33:40]

Patchset 4 (id:??) landed as
https://crrev.com/e4bcc542bf697b34f02250a7646fdb2da4a7f7a9
Cr-Commit-Position: refs/heads/master@{#407266}

[commit-bot: I haz the power, 2016-07-22 21:34:14]

Failed to apply the patch.