Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2179483002: Convert video-cookie* and video-error* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-cookie* and video-error* tests to testharness.js Cleaning up video-cookie* and video-error* tests in http/tests/media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4 Cr-Commit-Position: refs/heads/master@{#407346}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Use EventWatcher to simplify the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -127 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html View 1 chunk +20 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/video-cookie-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html View 1 1 chunk +32 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/media/video-error-abort-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-22 14:46:13 UTC) #3
fs
https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left): https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html#oldcode13 third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13: testRunner.setBlockThirdPartyCookies(false); This not needed? https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html File third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html (right): https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html#newcode8 ...
4 years, 5 months ago (2016-07-22 14:59:46 UTC) #4
Srirama
https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left): https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html#oldcode13 third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13: testRunner.setBlockThirdPartyCookies(false); On 2016/07/22 14:59:46, fs wrote: > This not ...
4 years, 5 months ago (2016-07-22 17:37:30 UTC) #5
fs
lgtm! https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left): https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html#oldcode13 third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13: testRunner.setBlockThirdPartyCookies(false); On 2016/07/22 at 17:37:30, Srirama wrote: > ...
4 years, 5 months ago (2016-07-22 17:44:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179483002/20001
4 years, 5 months ago (2016-07-23 02:42:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-23 03:44:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 03:46:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4
Cr-Commit-Position: refs/heads/master@{#407346}

Powered by Google App Engine
This is Rietveld 408576698