Convert video-cookie* and video-error* tests to testharness.js

Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4
Cr-Commit-Position: refs/heads/master@{#407346}

[Srirama, 2016-07-22 14:45:05]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-07-22 14:46:13]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-22 14:46:13]

PTAL

[fs, 2016-07-22 14:59:46]

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left):

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13:
testRunner.setBlockThirdPartyCookies(false);
This not needed?

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html
(right):

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html:8:
async_test(function(t) {
This looks like a test that might even be simpler (won't need the didLoad flag I
think) using EventWatcher, while testing the order of the events.

[Srirama, 2016-07-22 17:37:30]

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left):

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13:
testRunner.setBlockThirdPartyCookies(false);
On 2016/07/22 14:59:46, fs wrote:
> This not needed?

Its working without this as well and i removed it because the default value is
false anyway
https://cs.chromium.org/chromium/src/content/shell/browser/shell_network_dele....
Also it is changed recently from setAcceptAllCookies(true) to
setBlockThirdpatyCookies(false).

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html
(right):

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/video-error-abort.html:8:
async_test(function(t) {
On 2016/07/22 14:59:46, fs wrote:
> This looks like a test that might even be simpler (won't need the didLoad flag
I
> think) using EventWatcher, while testing the order of the events.

Done.

[fs, 2016-07-22 17:44:30]

lgtm!

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html (left):

https://codereview.chromium.org/2179483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/media/video-cookie.html:13:
testRunner.setBlockThirdPartyCookies(false);
On 2016/07/22 at 17:37:30, Srirama wrote:
> On 2016/07/22 14:59:46, fs wrote:
> > This not needed?
> 
> Its working without this as well and i removed it because the default value is
false anyway
https://cs.chromium.org/chromium/src/content/shell/browser/shell_network_dele....
Also it is changed recently from setAcceptAllCookies(true) to
setBlockThirdpatyCookies(false).

Ok. Let's assume that test will fail if incompatible changes are made.

[Srirama, 2016-07-23 02:41:51]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-07-23 02:42:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 03:44:37]

Description was changed from

==========
Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-23 03:44:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-23 03:46:57]

Description was changed from

==========
Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-cookie* and video-error* tests to testharness.js

Cleaning up video-cookie* and video-error* tests in http/tests/media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4
Cr-Commit-Position: refs/heads/master@{#407346}
==========

[commit-bot: I haz the power, 2016-07-23 03:46:58]

Patchset 2 (id:??) landed as
https://crrev.com/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4
Cr-Commit-Position: refs/heads/master@{#407346}