Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2179383002: Avoid using 'Yu Gothic' in tests to avoid flakiness (Closed)

Created:
4 years, 4 months ago by kojii
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using 'Yu Gothic' in tests to avoid flakiness These 4 tests are often flaky since some bots have 'Yu Gothic' while some don't. This patch avoids using 'Yu Gothic' in these tests. Committed: https://crrev.com/7c26ddb23b2b4c201e4fb54a321f190becd4938d Cr-Commit-Position: refs/heads/master@{#407749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/text/emphasis-vertical.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-lr-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-rl-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/text-combine-various-fonts.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
kojii
PTAL.
4 years, 4 months ago (2016-07-26 07:53:54 UTC) #6
yosin_UTC9
lgtm Please update description: s/oftentimes/often/ http://english.stackexchange.com/questions/65991/often-and-oftentimes
4 years, 4 months ago (2016-07-26 09:27:16 UTC) #10
kojii
Thanks!
4 years, 4 months ago (2016-07-26 09:30:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179383002/1
4 years, 4 months ago (2016-07-26 09:30:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 09:34:08 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c26ddb23b2b4c201e4fb54a321f190becd4938d Cr-Commit-Position: refs/heads/master@{#407749}
4 years, 4 months ago (2016-07-26 09:36:02 UTC) #17
vkuzkokov
On 2016/07/26 09:36:02, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 4 months ago (2016-07-26 13:35:23 UTC) #18
kojii
On 2016/07/26 at 13:35:23, vkuzkokov wrote: > On 2016/07/26 09:36:02, commit-bot: I haz the power ...
4 years, 4 months ago (2016-07-26 13:48:04 UTC) #19
kojii
4 years, 4 months ago (2016-07-26 13:48:05 UTC) #20
Message was sent while issue was closed.
On 2016/07/26 at 13:35:23, vkuzkokov wrote:
> On 2016/07/26 09:36:02, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7c26ddb23b2b4c201e4fb54a321f190becd4938d
> > Cr-Commit-Position: refs/heads/master@{#407749}
> 
> This seems to break Windows WebKit bots, e.g.
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

Thanks, it looks like win10 had different expect files, I'll rebase.

Powered by Google App Engine
This is Rietveld 408576698