Update Windows It2Me to allow remote users to interact with elevated windows

remoting/host/it2me/it2me_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 
 #include <memory>
+#include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/single_thread_task_runner.h"
 #include "remoting/host/host_status_observer.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog_proxy.h"
 #include "remoting/protocol/validating_authenticator.h"
 #include "remoting/signaling/xmpp_signal_strategy.h"
@@ skipping 139 matching lines @@
       const std::string& remote_jid,
       const protocol::ValidatingAuthenticator::ResultCallback& result_callback);
 
   // Caller supplied fields.
   std::unique_ptr<ChromotingHostContext> host_context_;
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   base::WeakPtr<It2MeHost::Observer> observer_;
   XmppSignalStrategy::XmppServerConfig xmpp_server_config_;
   std::string directory_bot_jid_;
 
-  It2MeHostState state_;
+  It2MeHostState state_ = kDisconnected;
 
   scoped_refptr<RsaKeyPair> host_key_pair_;
   std::unique_ptr<SignalStrategy> signal_strategy_;
   std::unique_ptr<RegisterSupportHostRequest> register_request_;
   std::unique_ptr<HostStatusLogger> host_status_logger_;
   std::unique_ptr<DesktopEnvironmentFactory> desktop_environment_factory_;
   std::unique_ptr<HostEventLogger> host_event_logger_;
 
   std::unique_ptr<ChromotingHost> host_;
-  int failed_login_attempts_;
+  int failed_login_attempts_ = 0;
 
   std::unique_ptr<PolicyWatcher> policy_watcher_;
   std::unique_ptr<It2MeConfirmationDialogFactory> confirmation_dialog_factory_;
   std::unique_ptr<It2MeConfirmationDialogProxy> confirmation_dialog_proxy_;
 
   // Host the current nat traversal policy setting.
-  bool nat_traversal_enabled_;
+  bool nat_traversal_enabled_ = false;
 
   // The client and host domain policy setting.
   std::string required_client_domain_;
   std::string required_host_domain_;
 
   // Indicates whether or not a policy has ever been read. This is to ensure
   // that on startup, we do not accidentally start a connection before we have
   // queried our policy restrictions.
-  bool policy_received_;
+  bool policy_received_ = false;
 
   // On startup, it is possible to have Connect() called before the policy read
   // is completed.  Rather than just failing, we thunk the connection call so
   // it can be executed after at least one successful policy read. This
   // variable contains the thunk if it is necessary.
   base::Closure pending_connect_;
 
   // Called after the client machine initiates the connection process and
   // determines whether to reject the connection or allow it to continue.
   protocol::ValidatingAuthenticator::ValidationCallback validation_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(It2MeHost);
 };
 
 // Having a factory interface makes it possible for the test to provide a mock
 // implementation of the It2MeHost.
 class It2MeHostFactory {
  public:
   It2MeHostFactory();
   virtual ~It2MeHostFactory();
 
-  // |policy_service| is used for creating the policy watcher for new
-  // instances of It2MeHost on ChromeOS.  The caller must ensure that
-  // |policy_service| is valid throughout the lifetime of the It2MeHostFactory
-  // and each created It2MeHost object.  This is currently possible because
-  // |policy_service| is a global singleton available from the browser process.
-  virtual void set_policy_service(policy::PolicyService* policy_service);
-
   virtual scoped_refptr<It2MeHost> CreateIt2MeHost(
       std::unique_ptr<ChromotingHostContext> context,
       base::WeakPtr<It2MeHost::Observer> observer,
       const XmppSignalStrategy::XmppServerConfig& xmpp_server_config,
       const std::string& directory_bot_jid);
 
+  // |policy_service| is used for creating the policy watcher for new
+  // instances of It2MeHost on ChromeOS.  The caller must ensure that
+  // |policy_service| is valid throughout the lifetime of the It2MeHostFactory
+  // and each created It2MeHost object.  This is currently possible because
+  // |policy_service| is a global singleton available from the browser process.
+  void set_policy_service(policy::PolicyService* policy_service);
+
+  policy::PolicyService* get_policy_service() { return policy_service_; }

[Sergey Ulanov, 2016/08/31 23:00:16]

This also looks out of place here. Factories should create things, but here you
piggy-back on it to pass PolicyService to It2MeNativeMessagingHost. Maybe just
pass PolicyService* to It2MeNativeMessagingHost explicitly? Then it could be
removed from here and replaced with PolicyWatcher parameter in CreateIt2MeHost,
but that's optional.

[joedow, 2016/09/02 21:58:59]

Great suggestion

+
  private:
-  policy::PolicyService* policy_service_;
+  policy::PolicyService* policy_service_ = nullptr;
   DISALLOW_COPY_AND_ASSIGN(It2MeHostFactory);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_HOST_H_