Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2179353002: Disable some tests with errors under TSan (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index e10b3e27eec3c682997159d6ce47d1a6718a0f4f..122d610109639f22f8fa5f0153760ef118b0009a 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -930,8 +930,16 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED);
}
+// Has errors under TSan. See https://crbug.com/631323.
+#if defined(THREAD_SANITIZER)
+#define MAYBE_InstallWithWaitUntil_RejectConsoleMessage \
+ DISABLED_InstallWithWaitUntil_RejectConsoleMessage
+#else
+#define MAYBE_InstallWithWaitUntil_RejectConsoleMessage \
+ InstallWithWaitUntil_RejectConsoleMessage
+#endif
IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
- InstallWithWaitUntil_RejectConsoleMessage) {
+ MAYBE_InstallWithWaitUntil_RejectConsoleMessage) {
RunOnIOThread(base::Bind(&self::SetUpRegistrationOnIOThread, this,
"/service_worker/worker_install_rejected.js"));
@@ -968,7 +976,14 @@ class WaitForLoaded : public EmbeddedWorkerInstance::Listener {
base::Closure quit_;
};
-IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, TimeoutStartingWorker) {
+// Has errors under TSan. See https://crbug.com/631323.
+#if defined(THREAD_SANITIZER)
+#define MAYBE_TimeoutStartingWorker DISABLED_TimeoutStartingWorker
+#else
+#define MAYBE_TimeoutStartingWorker TimeoutStartingWorker
+#endif
+IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
+ MAYBE_TimeoutStartingWorker) {
RunOnIOThread(base::Bind(&self::SetUpRegistrationOnIOThread, this,
"/service_worker/while_true_worker.js"));
@@ -1079,8 +1094,15 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
EXPECT_EQ("cache_name", response2.cache_storage_cache_name);
}
+// Has errors under TSan. See https://crbug.com/631323.
+#if defined(THREAD_SANITIZER)
+#define MAYBE_FetchEvent_respondWithRejection \
+ DISABLED_FetchEvent_respondWithRejection
+#else
+#define MAYBE_FetchEvent_respondWithRejection FetchEvent_respondWithRejection
+#endif
IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
- FetchEvent_respondWithRejection) {
+ MAYBE_FetchEvent_respondWithRejection) {
ServiceWorkerFetchEventResult result;
ServiceWorkerResponse response;
std::unique_ptr<storage::BlobDataHandle> blob_data_handle;
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698