[Findit] Compare lists to lists instead of lists to tuples, and change tests

appengine/findit/waterfall/try_job_util.py

Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index 5694e6a37b1edb6aa1898564ead3bd4f0e7cee3b..e0e6b7624a58306e3b727f42b1d8f914d2ce259f 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -206,6 +206,9 @@ def _CreateBuildFailureGroup(
 
 
 def _GetMatchingGroup(wf_failure_groups, blame_list, suspected_tuples):

[lijeffrey, 2016/07/27 22:49:36]

a change like this is better tested with unit tests that call this function
directly, once with suspected_tuples as an actual list of tuples and once with
it list-ified by json

[josiahk, 2016/07/30 00:21:11]

Thanks! I changed the code to use lists instead of tuples.

+  # Tuples get turned into lists with ndb.JsonProperty. WfFailureGroup uses
+  # ndb.JsonProperty to store suspected_tuples.
+  suspected_tuples = [list(tup) for tup in suspected_tuples]

[chanli, 2016/07/28 17:40:25]

Instead of modifying it here, you can just change GenPotentialCulpritTupleList
to directly produce the expected format.

[josiahk, 2016/07/30 00:21:10]

Thank you. I changed GenPotentialCulpritTupleList (side note: renamed to
GenSuspectedCLsWithFailures) to return list of lists instead of list of tuples.

   for group in wf_failure_groups:
     if _BlameListsIntersection(group.blame_list, blame_list):
       if suspected_tuples == group.suspected_tuples:
@@ -213,6 +216,7 @@ def _GetMatchingGroup(wf_failure_groups, blame_list, suspected_tuples):
 
   return None
 
+
 def _GetOutputNodes(signals):
   if not signals or 'compile' not in signals:
     return []
@@ -266,7 +270,8 @@ def _IsBuildFailureUniqueAcrossPlatforms(
     logging.info('A group already exists, no need for a new try job.')
     _LinkAnalysisToBuildFailureGroup(
         master_name, builder_name, build_number, [existing_group.master_name,
-        existing_group.builder_name, existing_group.build_number])
+                                                  existing_group.builder_name,
+                                                  existing_group.build_number])

[chanli, 2016/07/28 17:40:26]

Move the list to a separated line.

[josiahk, 2016/07/30 00:21:10]

Thanks!

   else:
     logging.info('A new try job should be run for this unique build failure.')
     _CreateBuildFailureGroup(