[Findit] Compare lists to lists instead of lists to tuples, and change tests

appengine/findit/handlers/triage_analysis.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module is to handle manual triage of analysis result.
 
 This handler will flag the analysis result as correct or incorrect.
 TODO: work on an automatic or semi-automatic way to triage analysis result.
 """
 
 import calendar
 from datetime import datetime
 from datetime import timedelta
 
 from google.appengine.api import users
 from google.appengine.ext import ndb
 import pytz.gae
 
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from model import result_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
-from waterfall import try_job_util
+from waterfall.try_job_util import GetSuspectedCLsWithFailures
 
 MATCHING_ANALYSIS_HOURS_AGO_START = 24
 MATCHING_ANALYSIS_HOURS_AGO_END = 24
 MATCHING_ANALYSIS_END_BOUND_TIME_ZONE = 'US/Pacific'
 
 
 def _DoAnalysesMatch(analysis_1, analysis_2):
   """Checks if two analyses match.
 
   Args:
     analysis_1: The first analysis to compare.
     analysis_2: The second analysis to compare.
 
   Returns:
-    True if the two analyses' sorted potential culprit lists match, otherwise
-    False.
+    True if the two analyses' sorted suspected CLs with failures lists match,
+    otherwise False.
   """
 
-  # Get list of potential culprit tuples.
-  potential_culprit_tuple_list_1 = (
-      try_job_util.GenPotentialCulpritTupleList(analysis_1.result))
-  potential_culprit_tuple_list_2 = (
-      try_job_util.GenPotentialCulpritTupleList(analysis_2.result))
+  # Get list of suspected CLs with failures.
+  suspected_cls_with_failures_1 = GetSuspectedCLsWithFailures(analysis_1.result)

[chanli, 2016/08/01 19:43:49]

This seems not correct. For try_job_util.GetSuspectedCLsWithFailures, it only
need to check heuristic results, but here we also need to check try job results

+  suspected_cls_with_failures_2 = GetSuspectedCLsWithFailures(analysis_2.result)
 
-  # Both analyses must have non-empty potential culprit lists.
-  if not potential_culprit_tuple_list_1 or not potential_culprit_tuple_list_2:
+  # Both analyses must have non-empty suspected CLs with failures lists.
+  if not suspected_cls_with_failures_1 or not suspected_cls_with_failures_2:
     return False
 
-  # Both analyses must have matching potential culprit lists.
-  return (sorted(potential_culprit_tuple_list_1) ==
-          sorted(potential_culprit_tuple_list_2))
+  # Both analyses must have matching suspected CLs with failures lists.
+  return (sorted(suspected_cls_with_failures_1) ==
+          sorted(suspected_cls_with_failures_2))
 
 
 def _AppendTriageHistoryRecord(
     analysis, is_correct, user_name, is_duplicate=False):
   """Appends a triage history record to the given analysis.
 
   Args:
     analysis: The analysis to which to append the history record.
     is_correct: True if the history record should indicate a correct judgement,
         otherwise False.
@@ skipping 143 matching lines @@
     # already logged in.
     user_name = users.get_current_user().email().split('@')[0]
     success, original_analysis = _UpdateAnalysisResultStatus(
         master_name, builder_name, build_number, is_correct, user_name)
     num_duplicate_analyses = 0
     if success:
       num_duplicate_analyses = _TriageAndCountDuplicateResults(
           original_analysis, is_correct, user_name)
     return {'data': {'success': success,
                      'num_duplicate_analyses': num_duplicate_analyses}}