Refactored signin/sync error controllers for the avatar button

chrome/browser/sync/avatar_sync_error.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_AVATAR_SYNC_ERROR_H_
+#define CHROME_BROWSER_SYNC_AVATAR_SYNC_ERROR_H_
+
+#include "components/sync_driver/sync_error_controller.h"
+
+class Profile;
+
+// Keep track of sync errors that are worth elevating to the user and expose
+// them to observers in the avatar button UI.
+class AvatarSyncError : public SyncErrorController::Observer {

[Roger Tawa OOO till Jul 10th, 2016/07/26 14:34:24]

Rename to AvatarSyncErrorController might be better.

[Jane, 2016/07/26 17:31:17]

Done.

+ public:
+  explicit AvatarSyncError(Profile* profile);
+  ~AvatarSyncError() override;
+
+  // SyncErrorController::Observer:
+  void OnErrorChanged() override;
+
+  bool HasSyncError() { return has_sync_error_; }

[Roger Tawa OOO till Jul 10th, 2016/07/26 14:34:24]

According to style guide this method should be named:

   bool has_sync_error()

or maybe more simply: bool has_error()

[Jane, 2016/07/26 17:31:17]

Done.

+
+ private:
+  SyncErrorController* GetSyncErrorControllerIfNeeded(Profile* profile);
+
+  Profile* profile_;
+  bool has_sync_error_;
+
+  DISALLOW_COPY_AND_ASSIGN(AvatarSyncError);
+};
+
+#endif  // CHROME_BROWSER_SYNC_AVATAR_SYNC_ERROR_H_