third_party/WebKit/Source/core/html/HTMLElement.cpp - Issue 2179273003: Implement spec-compliant HTMLElement.prototype.isContentEditable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2179273003: Implement spec-compliant HTMLElement.prototype.isContentEditable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLElement.h ('K') | « third_party/WebKit/Source/core/html/HTMLElement.h ('k') | third_party/WebKit/Source/core/html/HTMLElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp

index 109e8b45a3b0c2aa45eade29c6a8d508673ddd28..c0169f6f702897f29d1fb2bc83544457591593a9 100644

--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp

@@ -587,9 +587,9 @@ void HTMLElement::setContentEditable(const String& enabled, ExceptionState& exce

exceptionState.throwDOMException(SyntaxError, "The value provided ('" + enabled + "') is not one of 'true', 'false', 'plaintext-only', or 'inherit'.");

}

-bool HTMLElement::isContentEditable() const

+bool HTMLElement::isContentEditableForBinding() const

{

- return blink::isContentEditable(*this);

+ return isEditingHost(*this) || isEditable(*this);

}

bool HTMLElement::draggable() const