Implement spec-compliant HTMLElement.prototype.isContentEditable

Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has display:
none and users can't edit it.
So, we don't need to use the style-based editability to implement isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable

BUG=313082
Committed: https://crrev.com/57deef0bd2f6ff07999d84078630cc4ee9c11f80
Cr-Commit-Position: refs/heads/master@{#408035}

[tkent, 2016-07-26 10:25:32]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 10:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 11:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 11:30:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2016-07-26 14:35:21]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 14:35:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-26 14:36:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-26 16:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:06:21]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-07-27 00:33:36]

Description was changed from

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

BUG=313082
==========

to

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users' can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

BUG=313082
==========

[tkent, 2016-07-27 00:35:39]

Description was changed from

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users' can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

BUG=313082
==========

to

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users' can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable


BUG=313082
==========

[tkent, 2016-07-27 00:51:17]

Description was changed from

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users' can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable


BUG=313082
==========

to

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable


BUG=313082
==========

[tkent, 2016-07-27 00:51:43]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2016-07-27 00:51:44]

yosin@, yoichio@, would you review this please?

[yoichio, 2016-07-27 01:29:35]

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:314: }
If these functions are just for HTMLEelement::isContentEditable and no one
 won't use them, could you place them inside HTMLElement.cpp?
At least we need to name("isSpecedEditingHost" or something?) to avoid confusing
between existing *edit*-named functions.

[yosin_UTC9, 2016-07-27 01:34:36]

Oops, forgot to send.

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.h (right):

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.h:79: bool
isEditingHost(const Node&);
Could you rename |isEditingHost()| or |isEditable()| to 
 - |isEditingHostWithoutStyle()| or
 - |isEditingHostIgnoringStyle()| or
 - something other
to avoid use them in other than "HTMLElement.cpp".
Or, move to "HTMLElement.cpp" as static function?

WDYT?

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLElement.h (right):

https://codereview.chromium.org/2179273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLElement.h:62: bool
isContentEditableForBinding() const;
Thanks for adding a comment for this!

[tkent, 2016-07-27 02:21:06]

ok, I moved isEditingHost and isEditable to HTMLElement.cpp, and wrapped them
with anonymous namespace.
Please take another look.

[yosin_UTC9, 2016-07-27 02:23:20]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-27 02:23:21]

lgtm

[commit-bot: I haz the power, 2016-07-27 02:23:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 03:47:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-27 03:49:37]

Description was changed from

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable


BUG=313082
==========

to

==========
Implement spec-compliant HTMLElement.prototype.isContentEditable

Web-exposed isContentEditable and our style-based editability are different
concepts.  For example, the former should be |true| even if an element has
display:
none and users can't edit it.
So, we don't need to use the style-based editability to implement
isContentEditable.

Specifications:
 https://html.spec.whatwg.org/multipage/interaction.html#dom-iscontenteditable
 https://w3c.github.io/editing/execCommand.html#editing-host
 https://w3c.github.io/editing/execCommand.html#editable

BUG=313082

Committed: https://crrev.com/57deef0bd2f6ff07999d84078630cc4ee9c11f80
Cr-Commit-Position: refs/heads/master@{#408035}
==========

[commit-bot: I haz the power, 2016-07-27 03:49:38]

Patchset 2 (id:??) landed as
https://crrev.com/57deef0bd2f6ff07999d84078630cc4ee9c11f80
Cr-Commit-Position: refs/heads/master@{#408035}