Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h

Issue 2179273002: Mojo C++ bindings: support mapping T and T? differently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h
diff --git a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h
index fe88462014a89b7d4e1ed06a4aa87423d46ede6e..437aefe782a63005690130158b3825f2353daf18 100644
--- a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h
+++ b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h
@@ -124,11 +124,13 @@ struct StructTraits<test::MoveOnlyStructWithTraits,
};
template <>
-struct StructTraits<test::StructWithTraitsForUniquePtrTest,
- std::unique_ptr<int>> {
+struct StructTraits<test::StructWithTraitsForUniquePtr, std::unique_ptr<int>> {
+ static bool IsNull(const std::unique_ptr<int>& data) { return !data; }
+ static void SetToNull(std::unique_ptr<int>* data) { data->reset(); }
+
static int f_int32(const std::unique_ptr<int>& data) { return *data; }
- static bool Read(test::StructWithTraitsForUniquePtrTest::DataView data,
+ static bool Read(test::StructWithTraitsForUniquePtr::DataView data,
std::unique_ptr<int>* out) {
out->reset(new int(data.f_int32()));
return true;

Powered by Google App Engine
This is Rietveld 408576698