Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: components/ntp_tiles/most_visited_sites.h

Issue 2179233003: Start PopularSites fetch from separate function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/most_visited_sites.h
diff --git a/components/ntp_tiles/most_visited_sites.h b/components/ntp_tiles/most_visited_sites.h
index 2d77e18fc0aa34c3da8293a9b2ef10714e14da56..88caa3d67190ad7ffab57dccde0df1cb77b6a630 100644
--- a/components/ntp_tiles/most_visited_sites.h
+++ b/components/ntp_tiles/most_visited_sites.h
@@ -151,12 +151,9 @@ class MostVisitedSites : public history::TopSitesObserver,
MostVisitedSites(scoped_refptr<base::SequencedWorkerPool> blocking_pool,
PrefService* prefs,
- const TemplateURLService* template_url_service,
- variations::VariationsService* variations_service,
- net::URLRequestContextGetter* download_context,
- const base::FilePath& popular_sites_directory,
scoped_refptr<history::TopSites> top_sites,
suggestions::SuggestionsService* suggestions,
+ PopularSites* popular_sites,
MostVisitedSitesSupervisor* supervisor);
~MostVisitedSites() override;
@@ -232,12 +229,9 @@ class MostVisitedSites : public history::TopSitesObserver,
ChangeReason change_reason) override;
PrefService* prefs_;
- const TemplateURLService* template_url_service_;
- variations::VariationsService* variations_service_;
- net::URLRequestContextGetter* download_context_;
- base::FilePath popular_sites_directory_;
scoped_refptr<history::TopSites> top_sites_;
suggestions::SuggestionsService* suggestions_service_;
+ PopularSites* const popular_sites_;
MostVisitedSitesSupervisor* supervisor_;
Observer* observer_;
@@ -265,12 +259,9 @@ class MostVisitedSites : public history::TopSitesObserver,
MostVisitedSource mv_source_;
- std::unique_ptr<PopularSites> popular_sites_;
-
SuggestionsVector current_suggestions_;
base::ThreadChecker thread_checker_;
- scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
scoped_refptr<base::TaskRunner> blocking_runner_;
// For callbacks may be run after destruction.

Powered by Google App Engine
This is Rietveld 408576698