Issue 217923002: Make sure AudioBufferConverter uses aligned AudioBus channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217923002: Make sure AudioBufferConverter uses aligned AudioBus channels. (Closed)

Created:
6 years, 9 months ago by DaleCurtis

Modified:
6 years, 9 months ago

Reviewers:
rileya (GONE FROM CHROMIUM), scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make sure AudioBufferConverter uses aligned AudioBus channels. SIMD requires aligned loads or it'll crash. BUG=357840 TEST=new unittest. played video back in crashes. R=rileya@chromium.org, scherkus@chromium.org TBR=scherkus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260336

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	media/base/audio_buffer_converter.cc	View		1 chunk	+7 lines, -4 lines	0 comments	Download
	M	media/base/audio_buffer_converter_unittest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/217923002/1

6 years, 9 months ago (2014-03-28 23:51:57 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-29 01:26:30 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel

6 years, 9 months ago (2014-03-29 01:26:31 UTC) #7

DaleCurtis

6 years, 9 months ago (2014-03-29 01:36:48 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r260336 (presubmit successful).