chrome/browser/resources/settings/internet_page/network_proxy_input.js - Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_proxy_input.js

Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_3

Patch Set: Add MAX_NAMESERVERS Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_proxy_input.html ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_proxy_input.js

diff --git a/chrome/browser/resources/settings/internet_page/network_proxy_input.js b/chrome/browser/resources/settings/internet_page/network_proxy_input.js

index 6093bd4eba4eedad1a02f922560a9afcf68d1c05..9d807dc71f0738aa2fb4aa134ec7460f29b4e964 100644

--- a/chrome/browser/resources/settings/internet_page/network_proxy_input.js

+++ b/chrome/browser/resources/settings/internet_page/network_proxy_input.js

@@ -17,7 +17,7 @@ Polymer({

editable: {

type: Boolean,

- value: false

+ value: false,

/**

@@ -25,7 +25,7 @@ Polymer({

label: {

type: String,

- value: 'Proxy'

+ value: 'Proxy',

/**

@@ -34,8 +34,10 @@ Polymer({

value: {

type: Object,

- value: function() { return {Host: '', Port: 80}; },

- notify: true

+ value: function() {

+ return {Host: '', Port: 80};

+ },

+ notify: true,

@@ -44,6 +46,8 @@ Polymer({

* @private

onValueChange_: function() {

+ if (!this.value.Host)

+ return;

var port = parseInt(this.value.Port, 10);

if (isNaN(port))

port = 80;