Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3248)

Unified Diff: chrome/browser/resources/settings/internet_page/network_nameservers.html

Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_3
Patch Set: Add MAX_NAMESERVERS Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_nameservers.html
diff --git a/chrome/browser/resources/settings/internet_page/network_nameservers.html b/chrome/browser/resources/settings/internet_page/network_nameservers.html
index 7621c98a6c084d4084d6d6fcf037be0f6266e054..fa57eccbb24bfa122238037aedd7e167a56b3ae8 100644
--- a/chrome/browser/resources/settings/internet_page/network_nameservers.html
+++ b/chrome/browser/resources/settings/internet_page/network_nameservers.html
@@ -1,55 +1,37 @@
<link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input-container.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/paper-dropdown-menu.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.html">
+<link rel="import" href="internet_shared_css.html">
<dom-module id="network-nameservers">
<template>
- <style>
- #selectTypeDiv {
- margin: 10px 0;
- }
-
- select {
- padding: 5px;
- }
-
- paper-input-container {
- margin: -9px 5px 0;
- }
+ <style include="internet-shared">
</style>
- <div id="outer" class="layout vertical">
- <div id="selectTypeDiv">
- <!-- TODO(stevenjb): Use cr-dropdown-menu once available. -->
- <select id="type" on-change="onTypeChange_">
+ <div class="settings-box">
+ <div class="start">Nameservers</div>
+ <paper-dropdown-menu vertical-align="auto" no-label-float>
+ <paper-listbox class="dropdown-content" on-iron-activate="onTypeChange_"
+ selected="[[nameserversType]]" attr-for-selected="value">
<template is="dom-repeat" items="[[nameserverTypeNames_]]">
- <option>[[nameserverTypeDesc_(item)]]</option>
+ <button class="dropdown-item" role="option" value="[[item]]">
+ [[nameserverTypeDesc_(item)]]
+ </button>
</template>
- </select>
- </div>
- <div class="layout horizontal">
- <paper-input-container no-label-float>
- <input id="nameserver0" is="iron-input" value="[[nameservers.0]]"
- disabled="[[!canEdit_(editable, nameserversType)]]"
- on-blur="onValueChange_">
- </paper-input-container>
- <paper-input-container no-label-float>
- <input id="nameserver1" is="iron-input" value="[[nameservers.1]]"
- disabled="[[!canEdit_(editable, nameserversType)]]"
- on-blur="onValueChange_">
- </paper-input-container>
- </div>
- <div class="layout horizontal">
- <paper-input-container no-label-float>
- <input id="nameserver2" is="iron-input" value="[[nameservers.2]]"
- disabled="[[!canEdit_(editable, nameserversType)]]"
- on-blur="onValueChange_">
- </paper-input-container>
+ </paper-listbox>
+ </paper-dropdown-menu>
+ </div>
+
+ <div class="settings-box continuation single-column indented"
+ hidden$="[[!nameservers.length]]">
+ <template is="dom-repeat" items="[[nameservers]]">
<paper-input-container no-label-float>
- <input id="nameserver3" is="iron-input" value="[[nameservers.3]]"
+ <input id="nameserver[[index]]" is="iron-input" value="[[item]]"
disabled="[[!canEdit_(editable, nameserversType)]]"
on-blur="onValueChange_">
</paper-input-container>
- </div>
+ </template>
</div>
</template>
<script src="network_nameservers.js"></script>

Powered by Google App Engine
This is Rietveld 408576698